From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B8666EC58; Sun, 20 Jun 2021 20:17:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B8666EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624209467; bh=oQ/y56S8hCwOMkcQjlVc7xDwvpUb902ZrAdB/p3djZI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qOka6ADeHyC+pE/gcVm3CxhVQRv2FW2ufOg5+U05oFtVkdvDLtMbJTvMRgHHc4k7y w82niJbIsHsTQNAZg6bycnYQ8vNz+jhNhzEGtcQnay2InbihBKtUCObSv0zMi0Dpfz MtFdHYXLyeOvEtG9APfD/mSDx+TJR8GTXZtELxpM= Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 47B186EC58 for ; Sun, 20 Jun 2021 20:17:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47B186EC58 Received: by mail-lf1-f41.google.com with SMTP id x24so26048543lfr.10 for ; Sun, 20 Jun 2021 10:17:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CLjCXa0ro1dCTOTeZtTscFwKZSJl6WXDhoKdu7JU6lk=; b=YlHwUbrv9X78GCInbe38Z+OsdnMS77QwskZSZryV6/RA6hoD2tuHkOLzF1HXRoeBoP /55qqooulQ+q/2je55VsEmUoU6eHIOw4cp4vd9CxTNtNDai4Zdu7FQv4VMZpQqThFz62 +M0S6J1p3XTc679L24CCRV2YOM8eZrfPz0qDv5zNm/UA+JW2LL+iX3BhrKIwtr9+F/lu /xsA+ltq6Fm1X+qFfPj3ohTeGZI5K+u4WCld6Kts/E8QklGtEdk8Q9AH/xDj9ArxJPbA xGHmd6hzH7bDtyiNwogNsaA25QkJ2teeCTTd4F7pdtJd9Et8HgvmnDeocmclHOu/wS4M +6EQ== X-Gm-Message-State: AOAM530Sw/E+ODyL8xFfiibvqSJI6xQP9vfZBjGf73bzNe54j6WyFSva uv+jp3bDJSzZ0J2HfHPEPhpBfViCtyQ= X-Google-Smtp-Source: ABdhPJzwfTXLqFsrSRgs7tuyZZ5CAW/yY1sK4JnRxitO9/ySpN+260Zal+tkMyi/5HW6yH/Ifli08g== X-Received: by 2002:a05:6512:3457:: with SMTP id j23mr10979267lfr.146.1624209464148; Sun, 20 Jun 2021 10:17:44 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id m5sm1738706lfg.80.2021.06.20.10.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Jun 2021 10:17:42 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 173DF5A0020; Sun, 20 Jun 2021 20:17:42 +0300 (MSK) Date: Sun, 20 Jun 2021 20:17:42 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210615135630.63465-1-gorcunov@gmail.com> <3a60e5a6-ef92-2e30-c5e8-7e0db70728ea@tarantool.org> <657ec5d8-63e1-25e2-171e-f2ef862ad844@tarantool.org> <14359465-de4b-8475-f717-a3f19a053737@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14359465-de4b-8475-f717-a3f19a053737@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sun, Jun 20, 2021 at 04:50:10PM +0200, Vladislav Shpilevoy wrote: > > It looks better, but why did you ignore my first comment? > I remind it here: > > Maybe better rename it to gh-6035-election-filter. Because otherwise > this test is not included when I run `python test-run.py election`. And I > do that quite often when make a patch which affects election only. I didn't ignore it. Renamed it locally after I've sent you the fixes, simply because if was more convenient for me to make the rename as a last step. Everything is pushed into the branch. Thanks. src/box/applier.cc | 27 ++++++++++--------- src/lib/raft/raft.h | 7 ----- test/replication/gh-5445-leader-inconsistency.result | 15 +++++++++++ test/replication/gh-5445-leader-inconsistency.test.lua | 5 ++++ test/replication/gh-6035-election-filter.result | 139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ test/replication/gh-6035-election-filter.test.lua | 64 ++++++++++++++++++++++++++++++++++++++++++++ test/replication/gh-6035-master.lua | 1 + test/replication/gh-6035-node.lua | 34 +++++++++++++++++++++++ test/replication/gh-6035-replica1.lua | 1 + test/replication/gh-6035-replica2.lua | 1 + test/replication/suite.cfg | 1 + (I just looked into our repo and force pushed it again just to be sure)