From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B6F1F6E200; Sat, 19 Jun 2021 01:16:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B6F1F6E200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1624054614; bh=btfo4rlUzYCPAzZqC+31yupHIc81uiLyroA5IrP1bH4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CsUSjLLqFClkd/R78vzeGj6Z/d5UVN8n8vM1tJA6IwTud0mjNeXPgu5x4xuuEesXv 3lcepFO0rQQUDOEtV7GYGbHgtiEvRruMdV/rC11vmoackio0ZX1BxvjtaJ9xEXaVFj hKdWyh7Ke3PYGm2Eywpm7qujrpJHRFq9hSL//H5o= Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9D3506E200 for ; Sat, 19 Jun 2021 01:16:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9D3506E200 Received: by mail-lj1-f176.google.com with SMTP id d13so15907243ljg.12 for ; Fri, 18 Jun 2021 15:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bMwL72CTPrYx15KL7qmchsGmraGKP4NjkWtSYMzS4Rw=; b=g5RUist/wDd5nSjGKx9LJhPVM+5X8FAVPfmMopwQwPzbhm8cWO2RJ8odG46O4OOouN LRY75AdAaumhZtQR/yrlVq/DfmwOX2esGuq/gn7B157LLYe6Nx228Gqro/9DW1vIStJP lr1xaxgEgg4OiffVOUrVx+ZJFS2jd/WznzxWeihOsrcA+BiXQ3wDtHUnAMScV0n60kl6 7MRnUUnUfWa+HGBR0HYkP9zEyxDe+PCDihI+tyckvU3Bhhd4Bg8BEBlTUNOG96Muj10z YW8ktHL9b2EYxznZWi3Kdmp4l2lX5W7uTIcCtTbb/BKp6B6O2YEV7RgUFrKDN2TlYg8U Bnqw== X-Gm-Message-State: AOAM530aLbzXEsQKeDVjy+2fCPAVo0yyMzKDnMVINamk0Z+U3OCRir12 G01K7HZDwuW9YV5jUYwJg3ujQkGOvFs= X-Google-Smtp-Source: ABdhPJwJLckxC0PsOhZI4HnXqPGQIdf1t0lTJekyN59x2Y3vT4y1mQPPig+9c5W7Jciob318v1CXrQ== X-Received: by 2002:a2e:2e0d:: with SMTP id u13mr11655934lju.351.1624054611509; Fri, 18 Jun 2021 15:16:51 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id q21sm1129267lfp.260.2021.06.18.15.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 15:16:50 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 30F575A002A; Sat, 19 Jun 2021 01:16:49 +0300 (MSK) Date: Sat, 19 Jun 2021 01:16:49 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210615135630.63465-1-gorcunov@gmail.com> <3a60e5a6-ef92-2e30-c5e8-7e0db70728ea@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a60e5a6-ef92-2e30-c5e8-7e0db70728ea@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Jun 18, 2021 at 11:49:39PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > See 4 comments below. > > > diff --git a/test/replication/gh-6035-applier-filter.result b/test/replication/gh-6035-applier-filter.result > > new file mode 100644 > > index 000000000..7345a19f7 > > --- /dev/null > > +++ b/test/replication/gh-6035-applier-filter.result > > 1. Maybe better rename it to gh-6035-election-filter. Because otherwise > this test is not included when I run `python test-run.py election`. And I > do that quite often when make a patch which affects election only. Sure, I don't mind. > > +box.cfg{replication = {require('fio').cwd() .. "/replica1.sock"}} > > 2. You don't need require('fio').cwd(). "unix/:./replica1.sock" works > just fine. The same for the other socket paths. Actually I too this from other examples since I suspect the use of absolute path might be critical for test run engine. It is not a problem to rename but other our tests do use this trick so meaybe we should stick with same approach? Again, I don't mind to use relative path if this won't cause problems in future. > > +-- Make the master to be RAFT leader, this drops connection > > +-- to the replica2. > > 3. There was no connection to replica2 from master. > I'll update the comment, thanks! (actually replica2 connected to the master initialy and this is full duplex connection which we close on reconfig, that's what I meant saying "dropping" connection, but this seems to be confusing). > > + "gh-6035-applier-filter.test.lua": { > > + "memtx": {"engine": "memtx"} > > + }, > > 4. You don't need to specify the engine. You don't use the > engine variable in the test. Just leave it empty {}. OK