From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3AB6B6EC5B; Sat, 29 May 2021 01:30:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3AB6B6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622241012; bh=Y9ryQrfpprvQNYDyu3EDkbWkmUSdIRHkAJTPcIdhPB0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tfse095dExg0O42AGVAZPjv9eInEkS0eAOLB4abaCpjh18urycgyA/5TGAtCaOt5g BhsTYtnnY8r+52b+pDVMEJGh8jN/PwnArFuOgdS2Se6VJx8GMocWHwPInrUY7yx4Fm 6bjzmazvLgATZEGyKWk8FHSdXBeOjW3bIu6WuWSM= Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9F2F46EC5B for ; Sat, 29 May 2021 01:30:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9F2F46EC5B Received: by mail-lj1-f177.google.com with SMTP id w7so7116958lji.6 for ; Fri, 28 May 2021 15:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FcHLmxHQWe2bijR4IHpjFAkVSE9BbqYPFvcwGE/OoDw=; b=icfiLo/tlDIl/Z4qEcPyXbcuJekpalRXc4yxLWRxK+v1lSWt+suNDXDYlMrkGeYV51 3ZSKzX6qZFFv+/fKE7uS5qXiMansXxEobmQMJbbC1WJT/r065povw0nguFtlMirEAMeb MFrcOX0VCpwh7e/BSeAsG9+P6//oWobGLLvpvKYEwHsSAiwILM2fehTNkURA1mAZqX92 ZcsDSTCRoonRcZrL0yNqwuA/jJMYDgWfX6YK1H44Yhz28aOGUWB4yTIxfSIHaMeJXc8U IDkvpPpOXgf4WKLrgrIt63bbJEJZxVvpZx+fNwsxckbdKzP8w9jkpgaVwoHJRL9xQdao v13w== X-Gm-Message-State: AOAM531K2g3k0SCEMYmb4pEzxpc847Q32HQVHz/5peseIom/1uPmfYw2 gpXAlGZaXLw5g68VGeoTaz2OLvrjJrU= X-Google-Smtp-Source: ABdhPJxpPE72YSHZKRMRODXGfiBnMnPsTpkIe4xyjyIDqjQNa0pIaXmBuK6Tdp2BzQkxSojxDi6xvw== X-Received: by 2002:a2e:94d:: with SMTP id 74mr652642ljj.328.1622241009517; Fri, 28 May 2021 15:30:09 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id r9sm573047lfm.205.2021.05.28.15.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 15:30:08 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id DB2255A0042; Sat, 29 May 2021 01:30:07 +0300 (MSK) Date: Sat, 29 May 2021 01:30:07 +0300 To: Vladislav Shpilevoy Message-ID: References: <6ed9245f407510ad3a149f62c960f89fa689909e.1622233728.git.v.shpilevoy@tarantool.org> <705ae468-7849-7928-94ff-0ecefa6fdc07@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <705ae468-7849-7928-94ff-0ecefa6fdc07@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: check rs uuid on subscribe process X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sat, May 29, 2021 at 12:20:46AM +0200, Vladislav Shpilevoy wrote: > > > > Vlad, I didn't dive into the patch context yet but this > > use of *two* sequential calls of tt_uuid_str() is somehow > > suspicious. The tt_uuid_str uses single common buffer > > for any call which means some of tt_uuid_str() result > > will be overwritten, no? > > Nope, the static buffer is cyclic. Aha! Thanks for explanation!