From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4470D6EC5B; Sat, 29 May 2021 01:06:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4470D6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622239583; bh=8If6W5YpPQqDBhUTrYCz9tB9poXtbjnnOSimYwQ3e28=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tmVap2JIbCDe+WK836I9OAA98suLMTo0evwVXkw+90+3axkmyn3LNXZuehvBw5VKG MkDppJElEVtiHjHMEntX4iyLyVAODYvC+BX8wyDNPczoLnI7d5xVtFXynFaYBsRnT3 w1xlgeSR63wZXEioG+2FaxlsYbX12buA2eykBt8c= Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 933516EC5B for ; Sat, 29 May 2021 01:06:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 933516EC5B Received: by mail-lf1-f47.google.com with SMTP id b18so3264862lfv.11 for ; Fri, 28 May 2021 15:06:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ERCcxvQVJf6h9uIT1DDm7O7xfhB7OXRNgdXTraed6fg=; b=nUrhCUvvZRSWFzP7bzpSouV4XaTuy01yIPOYEDE+eCBTXUN2l0GUePug8on1quOskO Ok2JMV0y8O6Iruv7WOlb9L1el3OCH7CNnkQgzDsIrPh9A7n4kPd7hNB0d20atbnVIBOa 7ueuKbdmFHZo6rYwyq/vf+cfCjlXdE7kj6/9sHXmZqg0xpkVTy07w7NUuK4fV0XaorsN gCoTU01ETC5eQRABVPlzHLwSn9gG+APCchr3sToJDs4dX2vo5eEk+bZ43SZPo8L+SVW9 ++WJ9ZEuEk4bXOgkt/dLJmwqDT5+iPArIVbMV0demViYCLtbzWtEXyUba6TUxi9twcVr 4UPg== X-Gm-Message-State: AOAM530GZMAqZSdOqZUhxkWn81qtdcDzXvAWmhElSUQgE9oYwIkGBYFE c/NKUH6h0DM8i6qKPLt29w7R0YHK2gs= X-Google-Smtp-Source: ABdhPJxXTg8TelVpCWHRp312tReJ8vHiUI9qq7D3dr38VGwWLnWQcyFR6XctoN/iUwlzkmgmxm00cw== X-Received: by 2002:a05:6512:b13:: with SMTP id w19mr7030324lfu.381.1622239581611; Fri, 28 May 2021 15:06:21 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id n10sm671535ljj.42.2021.05.28.15.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 15:06:20 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 5F3325A0042; Sat, 29 May 2021 01:06:19 +0300 (MSK) Date: Sat, 29 May 2021 01:06:19 +0300 To: Vladislav Shpilevoy Message-ID: References: <6ed9245f407510ad3a149f62c960f89fa689909e.1622233728.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ed9245f407510ad3a149f62c960f89fa689909e.1622233728.git.v.shpilevoy@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: check rs uuid on subscribe process X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, May 28, 2021 at 10:35:42PM +0200, Vladislav Shpilevoy wrote: > + if (!tt_uuid_is_equal(&peer_replicaset_uuid, &REPLICASET_UUID)) { > + tnt_raise(ClientError, ER_REPLICASET_UUID_MISMATCH, > + tt_uuid_str(&REPLICASET_UUID), > + tt_uuid_str(&peer_replicaset_uuid)); > + } Vlad, I didn't dive into the patch context yet but this use of *two* sequential calls of tt_uuid_str() is somehow suspicious. The tt_uuid_str uses single common buffer for any call which means some of tt_uuid_str() result will be overwritten, no?