Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] qsync: handle async txns right during CONFIRM
Date: Fri, 28 May 2021 10:23:59 +0300	[thread overview]
Message-ID: <YLCajzOrB0mCuhEt@grain> (raw)
In-Reply-To: <c668a9e1ebedf79023c92b12cd53d069e0f79b04.1622150822.git.v.shpilevoy@tarantool.org>

On Thu, May 27, 2021 at 11:28:02PM +0200, Vladislav Shpilevoy wrote:
> diff --git a/src/box/txn.c b/src/box/txn.c
> index 1d42c9113..3d4d5c397 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -880,8 +880,14 @@ txn_commit(struct txn *txn)
>  	if (req == NULL)
>  		goto rollback;
>  
> -	bool is_sync = txn_has_flag(txn, TXN_WAIT_SYNC);
> -	if (is_sync) {
> +	/*
> +	 * Do not cash the flag value in a variable. The flag might be deleted

I suspect you meant "cache"? Obviously flag won't be paying any money :-)

> +	 * during WAL write. This can happen for async transactions created
> +	 * during CONFIRM write, whose all blocking sync transactions get
> +	 * confirmed. They they turn the async transaction into just a plain

"Then they" I guess? No need for diff, just force push an update please.

The rest of patch, looks ok to me, thanks!

  reply	other threads:[~2021-05-28  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 21:28 Vladislav Shpilevoy via Tarantool-patches
2021-05-28  7:23 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-05-28 19:13   ` Vladislav Shpilevoy via Tarantool-patches
2021-05-28  9:01 ` Serge Petrenko via Tarantool-patches
2021-05-28 19:13   ` Vladislav Shpilevoy via Tarantool-patches
2021-06-01  7:37     ` Serge Petrenko via Tarantool-patches
2021-06-01 20:59 ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLCajzOrB0mCuhEt@grain \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] qsync: handle async txns right during CONFIRM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox