From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ECA4D6C1AE; Tue, 18 May 2021 10:15:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECA4D6C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621322112; bh=lWw7ypH7kEshotAPXtUiShbKAorxJeziYWnW/ZQw1Ws=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=veRuxQ3YPbcwZGcFnBhDdlzqbldXecHxEFWcnEGJS5A/gbmbihqFEeTXFDcw5xlRj 9gREmKQSVlIXi3N4g5TYUxUQA6emNFeKsvPpVFbTwcetUdEiksAls1jE9S5E6gdsEH Z090sS7mumt4OWDGRSI5oj8JbybSefcGCuges8c8= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1D6436C1AE for ; Tue, 18 May 2021 10:15:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D6436C1AE Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1litwc-0006De-2Y; Tue, 18 May 2021 10:15:10 +0300 Date: Tue, 18 May 2021 10:14:03 +0300 To: Igor Munkin Message-ID: References: <72c91a259dd039fc95961992ae06baee820695be.1620072340.git.imun@tarantool.org> <20210517163433.GN3944@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517163433.GN3944@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0890FB394E039F71AA2C815CBBA0C08E7182A05F5380850406ADAC2ECE37A83F73E639739BC9EFED2B2E12CE6E820D60E6EC242FFC24CD075 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BD76697DAE49F8B0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2CFFD3BD24762A606834E320FEF699CDB50D7F87C0C4C56F2D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E625235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5D4FD4856343F5C54DF1C2D2CEDA68415855DF18174FB02E2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345CB6DE26F1654667449F8D1CB003DE8F13941A120DE1F0698B7775E0C633BBEA510D45EF51719D811D7E09C32AA3244C9CD6F89611A1535D699EED96768BAD469CA7333006C390A0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojdWksWVKfsTBArgsOfP2QdA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB47E25CCDDEFC90DE469540942E9AE0E6ACF0EC88E57EB1136F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 17.05.21, Igor Munkin wrote: > Oops, sorry guys, but the test seems to be noop for this fix (in other > works it's OK even without patch), so I've reimplemented it. Consider > the description in the test. Diff is below: Thanks for update! Please consider my comments below. Side note: Please, rebase your branch to master to make it buildable. > > ================================================================================ > > diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond > new file mode 100644 > index 000000000..2a2ec4d97 > --- /dev/null > +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.skipcond > @@ -0,0 +1,7 @@ > +import platform > + > +# Disabled on FreeBSD due to #4819. > +if platform.system() == 'FreeBSD': > + self.skip = 1 > + > +# vim: set ft=python: > diff --git a/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua > new file mode 100755 > index 000000000..72caec2f9 > --- /dev/null > +++ b/test/app-tap/gh-5983-jit-library-smoke-tests.test.lua > @@ -0,0 +1,44 @@ > +#!/usr/bin/env tarantool > + > +-- Just check whether all Lua sources related to jit.dump are > +-- bundled to the binary. Otherwise, jit.dump module raises > +-- an error that is handled via . > +-- XXX: pure require for jit.dump doesn't cover all the cases, > +-- since dis_.lua are loaded at runtime. Furthermore, this > +-- error is handled by JIT engine, so we can't use for it. > +-- Hence, simply sniff the output of the test to check that all > +-- phases of trace compilation are dumped. > + > +if #arg == 0 then > + local tap = require('tap') > + local test = tap.test('gh-5983-jit-library-smoke-tests') > + > + test:plan(1) > + > + -- XXX: Shell argument is necessary to differ test case > + -- from the test runner. > + local cmd = string.gsub(' 2>&1