From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 925B56EC58; Thu, 27 May 2021 14:03:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 925B56EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622113412; bh=1cJPlsAFsGos3VDItJHs61wPbOggRZsexmG3ue47UPk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=w0JdYqpLKyHpeQHiRMWvNLO/RNfVAdo2x6MlB4VWlc1k0H+dIe50DqvxGzNX6hk1Y vg3wBC/quDoaxjP/sOqzZ7qfjemWT7UMbfxmYk+ohUwozB45gjLYxv73Kuc81us08x Eg0LSDXNW4OBw26i0bnPuafd44pvbCEuOz17zGdc= Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 16DA36EC58 for ; Thu, 27 May 2021 14:03:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 16DA36EC58 Received: by mail-lf1-f47.google.com with SMTP id v8so7384316lft.8 for ; Thu, 27 May 2021 04:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bzwn1qYtfaOPO0AnxPwO40qTt+9oAjqb4JbE++dBG2E=; b=ZI2VOvWpZReTlK0bQ+ZMCjklced1+/ibblU4/BP1dnWdkPbTmUX5n2nV4Htxz2kwBG Mcj5AfROYcKEBHFrkxONNsy87GTo/fdQ6Q1CU2MZy81Li5jJ36u5ojlYWZrshRIQXRaW 2O01/3t03aqcLQoKfmoZeNj2f4+PBLAAzwBKZ/T1Egg+qOVxDAEUaSo6bE/UDjfeMmTL 5G2qOF28fvRtOFd8Td+IL9yW7z74vSsC+kF3jZpljhnrgZaQ/tHunBpzvZi2iqOJ2feo kDeyRDIxyz8SEs7cCZXSw9HZ89q6iDW7avUbISn0yBj4VfLNXFY76o5C70NwXfklzU/2 g6ig== X-Gm-Message-State: AOAM531ZBoXTVDzpSeO7khHAx+P3uWmrvHli4h/aLOH2uDnOrrOmv/nc MyXRqisZm7159t3yLBHTT4Cw/Jvu+Rk= X-Google-Smtp-Source: ABdhPJxkh7PLp1iEKvBobo/Q0MQgYWF4Bv1F0rRP9wlTeqAnJH+r7sEyamEvWFpUFvhGxR0x/z5nMA== X-Received: by 2002:ac2:48a9:: with SMTP id u9mr1939581lfg.173.1622113410001; Thu, 27 May 2021 04:03:30 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id z9sm126345lfu.260.2021.05.27.04.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 04:03:29 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 7CF5F5A0042; Thu, 27 May 2021 14:03:28 +0300 (MSK) Date: Thu, 27 May 2021 14:03:28 +0300 To: Serge Petrenko Cc: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org Message-ID: References: <8011f87bb9b5e1f53f5bee3124f3a8e9dbe1917c.1621935783.git.sergepetrenko@tarantool.org> <3552b10e-370d-ddbd-11ed-8c3d5310e651@tarantool.org> <008e0d5d-7b1a-0599-b76c-c3dc8a481d60@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008e0d5d-7b1a-0599-b76c-c3dc8a481d60@tarantool.org> User-Agent: Mutt/2.0.7 (2021-05-04) Subject: Re: [Tarantool-patches] [PATCH v2 2/2] box: fix an assertion failure in box.ctl.promote() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, May 27, 2021 at 01:53:54PM +0300, Serge Petrenko wrote: > > As decided in the chat, you can use txn->id. It is unique until > > restart and should help to detect if the last transaction has > > changed. > > Yep, thanks for the suggestion! > > Here's the diff: > Thanks! Looks ok for me. Lets wait for Vald.