From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 971A36F3C4; Tue, 11 May 2021 14:03:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 971A36F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620731015; bh=jfLiFY7q9c9Y9xqUk92K8+v+75O3YSChFTwS2xa8w1Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=m9ppZQortSS+6SU0/tLGU7FFeXZOcARHByp0akHj4WIYDh9Q69mjB7bl6gQD5lLoy QM24oJi18DUUxzcj7SG5sLvDwuq3v4/OjI0ZhivxycmPzmoGaeJxT5VtZ0Q6V0Gid7 2Qe8tPoKtJu2zps8aWQnRgN6SOuSolOsQVlh4viE= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 591EC6F3C4 for ; Tue, 11 May 2021 14:03:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 591EC6F3C4 Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1lgQAn-0004Dr-48; Tue, 11 May 2021 14:03:33 +0300 Date: Tue, 11 May 2021 14:02:28 +0300 To: Igor Munkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0AAE50420B6EFF6A4E51E23FC86C8E287182A05F538085040C89897E73D12FDE9DD230D1C9F9A7DD0A430672A5AF98D52105DB0BF948745A6 X-C1DE0DAB: 0D63561A33F958A5CAFABABCC1695E30F91022F4AD9E4D3B5FE3B9244D85F0BB8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A63B03BCD35E0C0A1CC5EA23B3B1BEA1832FCEA7E14B4E7114C4EB3A6B25B57169EB074137B715BD1D7E09C32AA3244CA58DAD9AC466D8D93E7DF0E8B32775B43C6EB905E3A8056BFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPN2Bz4bQWZtqbuUKNsRTFA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB42AF81E8EBA9BB88ACA688EDD4114549C9EF95AA7B19AEE03F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM! On 11.05.21, Igor Munkin wrote: > From: Mike Pall Side note: I am a little bit confused by this line (I thought that it is a part of the commit message). May be it is better to drop it or to write like: | # From: Mike Pall > > (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203) > > After Apple released Macs working on ARM64, the previous recipe in > lj_arch.h for detecting various Apple platforms is not valid anymore. > Fortunately, there is a system header (i.e. TargetConditionals.h), > provided by SDK with the proper defines to be set. Starting from this > patch, LuaJIT identifies Apple hosts via this header. > > Since testing machinery assumes that LuaJIT is built with JIT support > being enabled unconditionally, a smoke test for it is also added > alongside with this patch. > > Igor Munkin: > * added the description and the test for the problem > * backported the original patch to tarantool/luajit repo > > Part of tarantool/tarantool#5629 > Relates to tarantool/tarantool#5983 > > Signed-off-by: Igor Munkin > --- -- Best regards, Sergey Kaplun