From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9CDC76F3C4; Tue, 11 May 2021 00:58:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9CDC76F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620683917; bh=ND2x1Ee0O464nrE2kciXNjS8kxOELpFP6uDy8soC/bg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KLHV+Hl//PIrXtReQo0NQzwXp9TcpF5XeLPVJewH0jmxUqaUXBV2mnJnx82wmjHgd bto96M81Ttu5QqeJO9KleXmvtMLtHkRhJpkXcqda0weO6CttPsvhZV1ujndRQI1mZ0 yj0swFi4QqxLsMzOpJyx5TDOiEMWcTEpVeLm5/ew= Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5EBFA6F3C4 for ; Tue, 11 May 2021 00:58:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5EBFA6F3C4 Received: by mail-lj1-f171.google.com with SMTP id o16so22680842ljp.3 for ; Mon, 10 May 2021 14:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gc2fkQnUMjMDKG4aZx4h5xIGvD1aTTeF7jne9X2Xe2Y=; b=kTE4XxOK7vC/0Y1cOBvdN9YlE2fevXQJDn/xhr4a+J8ZQls2E97YOkV+FjMctogHkK 3pvnxCWOK/z55Byu+5h6FJrVra5po92ws4cDFDEY00kcecRYhCLtuxrgCGiM0pitwEu+ EZU8pFRywsECuKLeF99LKgDYO0kh+J3Gi5edBjYRC2FMNj3Z1FU2u7O8DhatzL6/2YFZ 5FcPecGnnoRSAuPrQ7V9I7XBfbs2PXkKqzhKsWDIdgx7jw9XJC84hJXv2fIfY1Ruak7J nkL+YFGDWql7+VqDJcDXYYgH4aubYhZPKUxd5OBK6SbglJLckrIVzwsExFUzQv37OfJN hxVQ== X-Gm-Message-State: AOAM532bT/zmYK7U0Z88ou+908fHoTYsC5n3OC20BS19DvBwNQdPaw/R 3rDnDMkb7uxsO8dddCuD/Hf8JQEjoRc= X-Google-Smtp-Source: ABdhPJzcNjUfme0gr6pyf7HpNEVmd3VhWKwVBF/bEEoKo0IXKeGjWSv5sa5VgNS78Um2VBl42n/2nA== X-Received: by 2002:a2e:3903:: with SMTP id g3mr21534459lja.133.1620683915437; Mon, 10 May 2021 14:58:35 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id z21sm2356433lfq.164.2021.05.10.14.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 14:58:34 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id E3F7A5A0019; Tue, 11 May 2021 00:58:33 +0300 (MSK) Date: Tue, 11 May 2021 00:58:33 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210504155819.290874-1-gorcunov@gmail.com> <20210504155819.290874-11-gorcunov@gmail.com> <25ed7418-5dfa-1650-ee92-94dc644a7934@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25ed7418-5dfa-1650-ee92-94dc644a7934@tarantool.org> User-Agent: Mutt/2.0.6 (2021-03-06) Subject: Re: [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, May 10, 2021 at 08:40:34PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > On 04.05.2021 17:58, Cyrill Gorcunov wrote: > > The position of first argument to check from is 6, not 0. > > Looks like our tests with CFORMAT was simply not working > > since commit 7d12d66e67a1ce843a2712980f4d3ba04bc0d4f2. > > Please, in addition to the hash add the commit title in > parentheses. > https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message Updated, thanks! I force pushed all updates.