From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ED5C76F3C4; Tue, 11 May 2021 00:55:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED5C76F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620683719; bh=6F8wW2uGFNyfO6bH2CVWHrGv0DWicrZUodm9rm0ioEQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iyOakfUZ5OJaIfChOnrSg0wUPymMJfFXr75mMDmiUddUL2cmhfiN1Jq9bvkRLMa5J QQVWxAfljPSmbQ/nV8jXVpQglXc1etn+gTkTZtwTjevfw5Pmnj+GgXfYPd7GGavJMY eamZhwM9WJohMQmWCndkhLMOpyfDbqeZx2lxIZog= Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DB4886F3C4 for ; Tue, 11 May 2021 00:55:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB4886F3C4 Received: by mail-lj1-f181.google.com with SMTP id v6so22650188ljj.5 for ; Mon, 10 May 2021 14:55:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zpsqy2G5a2ZTToF2fmm+mZEU2NEHgIpgBrzKg7sjI/c=; b=Q7Ps71sz9uV2Bxh5v8xpC4Je9zBAJ21lfIQTnIe8GNims11wnvaOI8ZmuEBG5EhqJ3 ojEyn8XXf6Fjo9WUWemMJaE0cznQOugkLqLa5OgzJlTHHn35IOO72zGrnCHf/JF/HzQH CJhAZD0xeHD9ZZ5T+3v/LwsLsBQlP+30Mdg7mwot2UChWCGNGX88xxafQlfjF62lgakW KiBk9lVJ3osr9VqNkqaCiBAb0TI97aV9hdNW+5FjeH4AJ4bjR7CgZA0J2CmyF9JdY+da Hd9t/MKylKlHZXGTbaraflXPJm/MHrXAbPRMsk7LFQTTrbazNEdaUa3QW4x8PQIFqiP3 ZrjA== X-Gm-Message-State: AOAM531bI1KR6jPzPdniFYqn7gqt6MFYJLI1fXlDuL+AfuzYGHP9FN6Y 7E1wuuv08Xnk56kda2LuujVv4icgp10= X-Google-Smtp-Source: ABdhPJz4ZmqbiEnsJMLEpM/ZtozgoxPYjUXyw8F0GLLkICSY0uPMOP1QeHnH52RIz+MHP+gHhMRDGw== X-Received: by 2002:a05:651c:1a4:: with SMTP id c4mr21890930ljn.112.1620683716845; Mon, 10 May 2021 14:55:16 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id a19sm2622758ljq.95.2021.05.10.14.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 14:55:15 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id B20B35A0019; Tue, 11 May 2021 00:55:14 +0300 (MSK) Date: Tue, 11 May 2021 00:55:14 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210504155819.290874-1-gorcunov@gmail.com> <20210504155819.290874-10-gorcunov@gmail.com> <3454dc30-572a-40c7-8d3b-f0cd0df84721@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3454dc30-572a-40c7-8d3b-f0cd0df84721@tarantool.org> User-Agent: Mutt/2.0.6 (2021-03-06) Subject: Re: [Tarantool-patches] [PATCH v3 09/10] wal: fix say_x format X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, May 10, 2021 at 08:40:32PM +0200, Vladislav Shpilevoy wrote: > Replica ID should be %u, it is unsigned. > Force pushed --- src/box/wal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/wal.c b/src/box/wal.c index fff530a38..63ff5584a 100644 --- a/src/box/wal.c +++ b/src/box/wal.c @@ -1013,7 +1013,7 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base, vclock_get(base, (*row)->replica_id) + vclock_get(vclock_diff, (*row)->replica_id); say_crit("Attempt to write a broken LSN to WAL:" - " replica id: %d, confirmed lsn: %lld," + " replica id: %u, confirmed lsn: %lld," " new lsn %lld", (*row)->replica_id, (long long)confirmed_lsn, (long long)(*row)->lsn); -- 2.31.1