From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BD87A6EC55; Mon, 3 May 2021 23:33:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BD87A6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620073994; bh=DWdXSqUjkKcRDGma//XFkxTicPKVkGnAUIf0ZTr5RcM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=oytCAGw41237kvSCXWaksGpTp77jVNgDIslPg5OeE0U3WJCHTAbLvPOcGC0fFQ/st kNwWctInnDMvgXFwR+zJHiBvZCJSDqozgqn0hbENMPKcABlAmqWr6+wcDwBqX7Y+on T74OG2zQRgdrb8ERFblKC+rw5AjG/jsS7ZiFHl2w= Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CD7986EC55 for ; Mon, 3 May 2021 23:33:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CD7986EC55 Received: by mail-lf1-f52.google.com with SMTP id h4so2359232lfv.0 for ; Mon, 03 May 2021 13:33:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JQlJlNvdUHZDdxbEaDLQ9gzm3qXiwnZhJ+2Az7/t9fE=; b=RuTJpyLYaYaWjHu4BXKzEc34Z5h9H8OqKRP2gleRwwOwoaia+M4zwtchwN8lvBAMPJ cAvPQhJWW40hsrfJSZBmApCi8tEcx8ZQEnD4DvEeTDbrDqy1L6TwIN/cs9DocVmrbIU2 vdZ4r7qoWsX9RuCCee2ZlqXTbHeHnb1ofBcZKQsqJWhW7wybFgqgSCxi4IfLQ8llLd5L tXahUadWfulGhljHvlP/KsRTTS/8iTAyorF+2FQRh5KvavfBwplHtiJTGd7Wm+SLW2Fe BlW8PePXAn43+GWio/R5UbWKDTYHgxrPryKaygPtNo2txqt5yQMFpexHUdqGVkNSWhJL JlQw== X-Gm-Message-State: AOAM533omhl7ie7KVeMKQrDnEcWhol0i+667Ru4MW5Kz5vvVXAL8uFi1 bukBh2J+HBkT/HeV7yHVsC0= X-Google-Smtp-Source: ABdhPJyHLlrjhXjK5vPfFIBTl4LWpRalb9ILuSizJ0ncw6Ws4m8AXYnvasvf5LD9w4E47n/kFUIvNw== X-Received: by 2002:ac2:47f5:: with SMTP id b21mr4210267lfp.300.1620073992394; Mon, 03 May 2021 13:33:12 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id r16sm1396651ljj.108.2021.05.03.13.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 13:33:11 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 4CD23560106; Mon, 3 May 2021 23:33:10 +0300 (MSK) Date: Mon, 3 May 2021 23:33:10 +0300 To: Konstantin Osipov Cc: tml , Mons Anderson , Vladislav Shpilevoy Message-ID: References: <20210430153940.121271-1-gorcunov@gmail.com> <20210430153940.121271-2-gorcunov@gmail.com> <20210503202109.GA6976@starling> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210503202109.GA6976@starling> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [RFC v3 1/3] xrow: allow to pass timestamp via xrow_encode_vclock_timed helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, May 03, 2021 at 11:21:09PM +0300, Konstantin Osipov wrote: > * Cyrill Gorcunov via Tarantool-patches [21/04/30 18:43]: > > We will enhance applier writer with timestamp of last written row. > > It is needed to detect downstream lag. > > LSN is already 64 bit and can very well fit a timestamp within a > very reasonable range (e.g nanosecond resolution, timeuuid range). > > I think you shouldn't add a new field, just change the way LSN is > generated. Kostya, I fear I don't get it. Currently we send back current vclock and in the header we have the "tm" field which has been unused before this patch. Now we start using it by sending timestamp there. Which exactly LSN you propose to change?