From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E90656EC5F; Fri, 30 Apr 2021 23:50:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E90656EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619815809; bh=LfLgDSvFMpDDp4IGp3jom5UT6lKm/3OWE7dfNuIBAKs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WrqqiNazRhoGQ8WUjjqIBlzoKfh5esCysmbvaNS0t1b6o2OR/+Z4S99KFSgfCpscO 89hgSPh9wf85MB/T5+egkJwFP5CH5R5TP0xZCYbRlJWhQQSRZr7PNs4oXQmdmJYX/z hrIuikR7BH7MbhYBkH+hJT0IlWolHH7xjJg470w8= Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0D2416EC5F for ; Fri, 30 Apr 2021 23:50:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D2416EC5F Received: by mail-lj1-f175.google.com with SMTP id u20so82352621lja.13 for ; Fri, 30 Apr 2021 13:50:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VU03oK3Tl1N3b9EAvjPycPATmd4lXNIryLhV6EEcB10=; b=a1ee/YH2gBYpuaeuYjgvLT9czZ3BD5F3frAQ4A3bsFCd51YCzkXW1peWsqhRazUpQn sBVXI5V5bA7tKWoEWSxmGibi9d5EldjwSALnWSrzcjlKKKex5UBH4VaVM5Fc4hDVyqog v7BRRQt2Rtefgwyn/X1vWw7jb0r6eCa5M4MaRICCqarS4MW59V1JkOVHhxiuCx9Zw8mG tGn6i/gWIPUYJqyoUwgT4FWjeuchhlvKBmUo21t2BN6Aa4SlEWSA6KPicrxGkJDVQI+w b7ytmZncYAX5SyCs/h3OVGy9xE8QX00976lY37NuLto37xaBRE096FpNWZ5hV9HJhFAJ /zDA== X-Gm-Message-State: AOAM5311Vjcpk/zKj1vm+rTr//2OSwjlmERFegsLgmAnGCRSOP701aAS QgSIkQPPVS+6AfT0KAiVe4s= X-Google-Smtp-Source: ABdhPJwXbOnHOMN/G+SC7N6KyfDKs8ULFQdzHq0uozZpYScHBHFsBbf2uOPCso/WpcswbB4pPMuXgw== X-Received: by 2002:a2e:a793:: with SMTP id c19mr5152551ljf.75.1619815806594; Fri, 30 Apr 2021 13:50:06 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id r124sm381168lff.13.2021.04.30.13.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 13:50:05 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 71B49560200; Fri, 30 Apr 2021 23:50:04 +0300 (MSK) Date: Fri, 30 Apr 2021 23:50:04 +0300 To: Vladislav Shpilevoy Cc: tml , Mons Anderson Message-ID: References: <20210430153940.121271-1-gorcunov@gmail.com> <20210430153940.121271-2-gorcunov@gmail.com> <3289b448-233e-efa6-2e62-79c5eedee62b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3289b448-233e-efa6-2e62-79c5eedee62b@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [RFC v3 1/3] xrow: allow to pass timestamp via xrow_encode_vclock_timed helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Apr 30, 2021 at 10:45:48PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > I am not sure it is needed though. You can simply assign tm after > encode(). Grep `xrow_encode_vclock()` to see examples where sync > is assigned after encode, it looks fine. > > Too many changes just for a single usage. Sure thing, will update.