From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 83FB26F865; Thu, 29 Apr 2021 23:39:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 83FB26F865 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619728775; bh=luta4TMT1yu0tvEEbm3dkBPBdginyKYBXkMG6O9svcA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HofGxej6Jsbj0Oq00e4b++qis0JWPhKEjX2DYJNdbuec6hqdjDWjY8bu0svecxLBN DynNuRM5UKuDpK4rSLoF+7sZGVoKE3fYKnrlgUBJ6xIkaBX/nS0BvH7XT61s2b3XEz 2DwZObQj/WBfIho29c+pTQSNrDG50qYq7UeYpo4k= Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 237966F865 for ; Thu, 29 Apr 2021 23:39:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 237966F865 Received: by mail-lf1-f44.google.com with SMTP id c11so2881667lfi.9 for ; Thu, 29 Apr 2021 13:39:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eVfzUIQPMpY2sx1ynzAQBaavgY83uvO9y73d9JenYQQ=; b=KoQzuFU/RXIzFwyQbL9NWcrPZc2UonmIgD8VKlZYC4oGfxkTyjAzFyW3A34UBWiVgx OYuvxQs7AdGg9aOkhaGsWs+BJfPRh1xLceclp86mxPB0yrT/pYINaN/QG+bMtiBGsL8h T9udYkCwHhUXS3W7YVzS3TkjwIFwJJ6+LtQJn1ueONOtTWoWNPZHh+tWyYTZV5k5ivxw x3fJZBFpnSNbfCvM9nsLmDJ5MxhbpDNOUijFRzDBqNqh6w7tXU37vPT0vQGcmsMcyg/g wCdYhcQX7eRhpvBAJerXGHPIhh3aY1Yb3dpx+GRuT60sHlIOEk25s26LB2PcXzOqCFHi 47pQ== X-Gm-Message-State: AOAM531z9MoSIiN+LoGdIFx/dAd6JN8SJKCv9h3XXf9kZIPn4vY5qiye lmOfz9MEs8ez0XykTgZ2RwfkHAYFD5Y= X-Google-Smtp-Source: ABdhPJwIjRmSSO2SD9NWKGazucGc1pdVMU0v1dv/9AxG+Ju5Sh0t7sRaEox4UCS3ZIrPJR+2z9448w== X-Received: by 2002:a05:6512:21c7:: with SMTP id d7mr934152lft.332.1619728772796; Thu, 29 Apr 2021 13:39:32 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id b10sm617028ljr.109.2021.04.29.13.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 13:39:31 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id DA22C560156; Thu, 29 Apr 2021 23:39:30 +0300 (MSK) Date: Thu, 29 Apr 2021 23:39:30 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210428102251.552976-1-gorcunov@gmail.com> <20210428102251.552976-3-gorcunov@gmail.com> <76ab28d4-6556-9368-7219-8dc0c40dccc4@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76ab28d4-6556-9368-7219-8dc0c40dccc4@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v3 2/2] fiber: fiber_join -- don't crash on misuse X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 29, 2021 at 09:37:56PM +0200, Vladislav Shpilevoy wrote: > > +* Fixed lack of testing for non noinable fibers in `fiber_join()` call. > > + This could lead to unpredictable results. Note the issue affects C > > + level only, in Lua interface `fiber::join()`` the protection is > > fiber::join() -> fiber:join() > > And `` -> ` in the end. Force pushed an update. Thanks! branch gorcunov/gh-6046-fiber-join-3 --- changelogs/unreleased/gh-6046-fiber-join-misuse.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/unreleased/gh-6046-fiber-join-misuse.md b/changelogs/unreleased/gh-6046-fiber-join-misuse.md index 32c15566d..4515d96a8 100644 --- a/changelogs/unreleased/gh-6046-fiber-join-misuse.md +++ b/changelogs/unreleased/gh-6046-fiber-join-misuse.md @@ -2,5 +2,5 @@ * Fixed lack of testing for non noinable fibers in `fiber_join()` call. This could lead to unpredictable results. Note the issue affects C - level only, in Lua interface `fiber::join()`` the protection is + level only, in Lua interface `fiber:join()` the protection is turned on already. -- 2.30.2