From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 07D0A6FC86; Sun, 25 Apr 2021 16:27:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 07D0A6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619357221; bh=+WxwjrFfrBCM9MdGy/q2gIVoP6LGkOtsc2ajIJbckzE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=v1vRomc2PEQl2ajsMjy8KYoAEnAZe7txfRp4DxRDA40g4u3kJ5M4AyZ/JR9QMgnXj 0zttE6equq/YXF2zfF761f1xUAsbedTH1uicBEtlxVcV2weY26g8gydA92kPVkuvs0 tlhdUlnORJNpYWdh6EWu/JuWrFMAcn7PRd4EAh+Q= Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 453ED6FC86 for ; Sun, 25 Apr 2021 16:27:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 453ED6FC86 Received: by mail-lj1-f174.google.com with SMTP id a13so7080390ljp.2 for ; Sun, 25 Apr 2021 06:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CAIqirUdiNKWRd46mcYKzM4zwsvWFFlyVId6FDDWaoU=; b=UuNGInGKEXUFqCNVOTkWVnI+M5XTDsAV7rZAed/0PuuQ7jFIsGkYVphjhZy0KfWg+Y xBzPk8cc2N39+htNovoTC/XcatHVz5Z7YE8f94SCX032uxKhG4blQRHSbPY2hXh5XiGH 3YZjCwV+aVh91+qbN1a3LkJZmpYVdw38FmCXLwcI3sdtgciVQgPSjuvjyLEImtdshelV d/DydW6nvZMPhWhgseCkeHCPvDA5fxULU7d+ZNXSz2lGwXFu+z++6WNcJ4QmbuzNFRCj M7ftRkH+l64ctXAXeDHZt7ttOs0yi2M5uGKDlH6mNlI0LLAouzNPD7DwbfNxUAvCw4qL m0wQ== X-Gm-Message-State: AOAM5317xb9mUEng11Mc6Dh+HAQPif42NBpbTgLUJ+1mEoe7VyASIecZ TpUZOjPmunsCzUibLccarIhP94Ey2JLVVA== X-Google-Smtp-Source: ABdhPJy5rimcSYzt4+euMzqDpYd/K9Gv/kxkiyBWMMvMd7PtizVLEV3O5cVax2JjuuznhMa1SVeACw== X-Received: by 2002:a05:651c:1244:: with SMTP id h4mr9514311ljh.410.1619357219250; Sun, 25 Apr 2021 06:26:59 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id b23sm1106411lfe.284.2021.04.25.06.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 06:26:58 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 8174756014D; Sun, 25 Apr 2021 16:26:57 +0300 (MSK) Date: Sun, 25 Apr 2021 16:26:57 +0300 To: Serge Petrenko Cc: Vladislav Shpilevoy , tml Message-ID: References: <20210419083719.29689-1-gorcunov@gmail.com> <20210419083719.29689-2-gorcunov@gmail.com> <68c7c11c-758b-5513-de57-1150c16689d8@tarantool.org> <48231b42-debd-ac18-2a97-bbfa9b4aec5b@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48231b42-debd-ac18-2a97-bbfa9b4aec5b@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sun, Apr 25, 2021 at 11:08:25AM +0300, Serge Petrenko wrote: > > +enum wal_mode { > > + /** > > + * Do not write data at all. > > + */ > > + WAL_NONE, > > + ... > Thanks for the patch! > > I'd leave an explicit WAL_NONE = 0. > I didn't know that enums start at zero, TBH. Yeah, this is a part of language standart. > This would be more readable IMO. I'll make it so and force push. Thanks a huge for review, guys!