From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 62F236B962; Wed, 14 Apr 2021 11:34:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 62F236B962 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618389249; bh=wGAIe+406tsDP/jGBnQ9+ATA/X75SHcVIEdFuP4xQps=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=kd9ekImWt6QVykGEFhW4vslRaWJlawNqPffzyekgmzFi5EoEeveK5/zW3JW2pFbqL i/gzpNgP29T5R5d5MMt9DQ+MKNpWaDkl4j8krKk68RSX3RGHEOpZqb8GDfrsLJhgoD BTT9hc4ufxxKel4GXHbunu7ZDO4U+VdR41fCEga0= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 582BC6BD23 for ; Wed, 14 Apr 2021 11:34:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 582BC6BD23 Received: by mail-lf1-f46.google.com with SMTP id g8so31836884lfv.12 for ; Wed, 14 Apr 2021 01:34:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sSECtnfnASK3a1JIbb7gG/ioAXupDOVxcdNZfqKJLcM=; b=mZET8nZqovrf2N3NHnz6KxzrUtzM/eqYKRh8/4pzelYPEpYIrpmTPlCpF54+gOCcO+ 3Elb3S7BCpuYIp0xDpr4jpjx49D3CCk1B29Q9A9pticfbNFarsC5RH/+wppwmlfTkQF4 5bAPdA2Zo8zAcjHyw7ZlzGn/Nz1Jo5U5FZxWJHa8BQ0LYKaq61/KzEZAZ16737Ntjtt9 3PMoGoFVKHN5ab44hNzj8wcRu3dt+loM6fKVmVdf5pkGg/tE0SSzCzmvrq+gmwWZfKBS li/fHI1tVIG+y5fHh6K7pXh1cH3Kic9KHwnTOJyvPREASax11MpBOIf0zmpBCN3R45RB tyuw== X-Gm-Message-State: AOAM5336GO5D0aPN/cHWoZeDadd2UxnR7I8DTAa9Scq6/7f4rMB7nBsk nmWEpUyR9KtNxBsb2CWtmfikp4th47hBVg== X-Google-Smtp-Source: ABdhPJw7O6cQlMN7t41KiW+yXYwFwor8EC265p8jLJJwlnYwrdEHaaLbm6McP1+uy4wCtt6SpeN/Ag== X-Received: by 2002:ac2:5a4e:: with SMTP id r14mr17396402lfn.78.1618389247219; Wed, 14 Apr 2021 01:34:07 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id g9sm5031787lja.134.2021.04.14.01.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 01:34:06 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id A088556010D; Wed, 14 Apr 2021 11:34:05 +0300 (MSK) Date: Wed, 14 Apr 2021 11:34:05 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <150875bcbaaa0b7c270c1d53dc623892312fe16d.1618256019.git.sergepetrenko@tarantool.org> <86a5cfc2-ee8b-c781-472e-8a91bdf00246@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86a5cfc2-ee8b-c781-472e-8a91bdf00246@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2 4/9] box: make clear_synchro_queue() write a PROMOTE entry instead of CONFIRM + ROLLBACK X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Apr 14, 2021 at 11:23:23AM +0300, Serge Petrenko wrote: > > Is there some particular meaning of zeroifying designated assignments? > > I mean why not simply > > > > struct synchro_request req = { > > .origin_id = instance_id, > > .lsn = wait_lsn, > > }; > > > > or you wanted to pay attention that the left of the fields are > > unused? Just curious, I'm fine with current code. > > I went for your option at first, and it's the one I'd prefer. > But with it I got failed builds in some CI jobs. > > It said something like "sorry, not yet implemented: struct partial > initialization" Ah, Serge, it is because of C++ compiler, not C. Sorry ;)