From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A95A46B944; Tue, 13 Apr 2021 18:03:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A95A46B944 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618326209; bh=py01jfrbfDRN7RkwJGKq8yhGMT/cIPqJvdzxmr7sxUY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FvdEB//9NrVz/zbXlFZ0b/O9j/z/fSYcDzFWu4cHEF9XcNcJPnklf0abAV97Zbnb6 cValxGDrH4mmD4JpEVUMCMUYZ9i4xohWz+3H8xRuEQxhoQo4JEKXcXzXEDN5Web/v7 92ooCJVSjHZJIkvVEW8dZNCc1QxquI1YvNe3IgbA= Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0AA3B6BD2D for ; Tue, 13 Apr 2021 18:03:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0AA3B6BD2D Received: by mail-lf1-f45.google.com with SMTP id n138so27939352lfa.3 for ; Tue, 13 Apr 2021 08:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2FvbsTLdO1NhBxaCzmU/PgeWjM0AOnaAEgdpbE8zERc=; b=FUHLm+7Z1f+fHit9hcRhbkkSPYYF60J/ijVPYVUPQyZecpFkSPq39xuDPEDjdVYEab hSuZjt7JeSvjtz0ipFXc2zK/SVli0AgsBHlxqrHNSb1lLxXKw8lt1R5Hd97bAgtGCPX8 endsvvt6tYVha0z4ZeMAs5Pa0X3l7foBlz+ALgvUuNW5fXnwXDko2CHi7oZGwHTXUAlM Jt7L0eWsM0TNt2h0A3Xue56XlnRI/GwcHoPb53+3+pbLO6o8vvPb6lj7EBgefuif9Cfa 2k7mY402bquvvBO+t1U9tfpSOEux3PtPoLZGaDPO3wulAWHR9o4m6Btv7IGX+7CdDIvW xEsQ== X-Gm-Message-State: AOAM532Hi+dkuY2P5LYZGxYgQgM/l1fKS+XoIoGwGbKJgNzqId/0FjKT 0DjVe3obY/p3NKeD074KaT9U5xUJBzE= X-Google-Smtp-Source: ABdhPJxZ7FE78QZm2mSQLAiWF7G3OTnFqj2e8i70ZoEM4Y4iERi93aDqLSjC31lY9lp32P1GMRQ96g== X-Received: by 2002:a19:50d:: with SMTP id 13mr22084233lff.443.1618326207810; Tue, 13 Apr 2021 08:03:27 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id m1sm3402871lfu.206.2021.04.13.08.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 08:03:26 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 87793560162; Tue, 13 Apr 2021 18:03:24 +0300 (MSK) Date: Tue, 13 Apr 2021 18:03:24 +0300 To: Leonid Vasiliev Message-ID: References: <20210413124559.47410-1-roman.habibov@tarantool.org> <20210413124559.47410-2-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2 1/2] lua/log: remove 'module' option type X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Apr 13, 2021 at 05:52:11PM +0300, Leonid Vasiliev wrote: > Hi! Thank you for the patch. > LGTM. > Cyrill Gorcunov. please also see the patch. > Guys, I don't like that we're dropping the "module" here. But please gimme today's evening I'll try to come up with some idea and code to share, ok? I'll write another email once I get ready.