From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9F4566BD2D; Tue, 13 Apr 2021 17:16:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9F4566BD2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618323401; bh=945VE1LPqz1YeHiMNuuAnG/XdISksye7Un+APmdzk9U=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KpkUWIjSKKwCJTzkRt9vcy6QhGfNOh6z+3yuGTlWmNVMSjaIrKmh0ZgHtxxgjX1GO zKEJtA0jQ8zbH3gn2SHNdgKXHBecKroOQb1RHQcZLv202Wv3AvFr77JvAjixAHvTQA 0vfNXOuJ2cx3qJPdxDvZut8NjuHu9K8aauprdJ0w= Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 390456B944 for ; Tue, 13 Apr 2021 17:16:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 390456B944 Received: by mail-lj1-f181.google.com with SMTP id o16so19536035ljp.3 for ; Tue, 13 Apr 2021 07:16:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=EdpmQ50ZrVVSPdbZiI+JuV9efk0kRZc+0fbPob9LkTc=; b=euNq2xj3LDB4BXWdybn/qYjf6prDvRFqSuqvlfGX0ySkg5OCRQGrx9CPAE7ejnmvOa UDxMlK0pkRyeBNMO6BBIoRWzCi2frcxoHFUhVFZoFWOnBleg2AvJ5kj8SAZFIxHYsJhH sXO8uFDf+Kgue28HWJ3sEqMYkGpAcCFU5fCQy/4E5GfU5qwf8BHaAioNDZkpQ5uPfkg9 nsfN7BQLZc1oBp/iWfyBGQsIg4+ORoaoXF7NYhq3Cda18cFXJHh9dKgXZxTNIyaufWWz AQWagGnHB9t+EcQs1PiDFzOmMJY3UvqVOS0Ic+Jt4/24u1Pk/l1NYGk0H+Q+b9nuU51f 8C9w== X-Gm-Message-State: AOAM531jHC+G/XBF18zEtiSsV/wW6txIOIeXLSEMLturce0q0hybWDe4 wCFFnNrnjLFCRjZSN+x/0CQhvOOATFs= X-Google-Smtp-Source: ABdhPJxnj6AORKdmshUaCu8ASBsn3ijaf4zpA0sMABpi5WopiYJ+HH/h/CVeIOZLD5IHRXByuWfJTg== X-Received: by 2002:a2e:2ac6:: with SMTP id q189mr18607120ljq.474.1618323399197; Tue, 13 Apr 2021 07:16:39 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id 125sm4006740ljj.15.2021.04.13.07.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 07:16:37 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 99347560162; Tue, 13 Apr 2021 17:16:36 +0300 (MSK) Date: Tue, 13 Apr 2021 17:16:36 +0300 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: References: <0d29b025b7213b5c9596715d849b4b371e1fef32.1618256019.git.sergepetrenko@tarantool.org> <90b3cd45-b633-e7e1-8547-0e04aebcf522@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90b3cd45-b633-e7e1-8547-0e04aebcf522@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2 1/9] wal: enrich row's meta information with sync replication flags X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Apr 13, 2021 at 04:51:52PM +0300, Serge Petrenko wrote: > > > 13.04.2021 14:50, Cyrill Gorcunov пишет: > > On Mon, Apr 12, 2021 at 10:40:14PM +0300, Serge Petrenko wrote: > > > Introduce two new flags to xrow_header: `wait_ack` and `wait_sync`. > > > These flags are set for rows belonging to synchronous transactions in > > > addition to `is_commit`. > > > > > > The new flags help to define whether the rows belong to a synchronous > > > transaction or not without parsing them all and checking whether any of > > > the rows touches a synchronous space. > > > > > > This will be used in applier once it is taught to filter synchronous > > > transactions based on whether they are coming from a raft leader or not. > > > > > > P.S. These flags will also be useful once we allow to turn any transaction > > > synchronous. Once this is done, the flags in row header will be the only > > > source of information on whether the transaction is synchronous or not. > > > > > > Prerequisite #5445 > > Serge, here is a one addition: lets verify bitfields order. While their > > use indeed is suitable we should eliminate ourself from unpredicted results. > > The test is for c++ and probably we need one for plain c compiler as well? > > Thanks for the help! I've added your tests with some changes. > What do you think? > Ack