From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2105E6EC5D; Tue, 6 Apr 2021 10:44:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2105E6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617695055; bh=jY+CTrBNAuom5v0Xua4R65z47XQTrgX5yhzEsdf4gME=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=yOCBx7kh4vCKWa9pPhiK4xZ2X4Gv1zGAA07NPHUJAHPflMlNPrpRS+EkLne95HISR YOnUis7bFQc2tgKe0jA0k5ofoa4PiRK+EQKXWuEy/nZntCQNYwuO6bcFqAL+bqHGdj wc2IYWE6KnU+mt/DDLQhzxtehJp2AGtQ4dDz2+to= Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A2C8F6EC5D for ; Tue, 6 Apr 2021 10:44:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A2C8F6EC5D Received: by mail-lf1-f54.google.com with SMTP id v15so21224814lfq.5 for ; Tue, 06 Apr 2021 00:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e2HLygRorHEovzu0XOaGITxtL//9HIq1SsO4IP5VWP8=; b=il9Z/HqVExMjfsBWIgWgBzaofpbvT7yyNVR/OTvg7bIXN3Ia0LKPcjmkxXgsbmg7C/ DHiA9RNdhUs3KaVLZR4s94zXofNQxrPsYpoArGwrofRRBbM6uh87q1u34H54HezJtIxZ FEP52XFo1oSNQcvOzXttTc2vuw4bOzX71PKWjT5fzlGXI44D7DbF0wHCeHOxk+7sdto0 JCv4JwyJIq+3AkUXPv8Txjf8vKF+Ke6aak40a7gecEKBpzkjuMPrSy5cieR8QwpYYplV 6rvZ6fULAMZSorlChOYsh50D7TEE/E2xmWCgglDvGiRmzyF028U4YV/d6i3VAAH02BKP JW9A== X-Gm-Message-State: AOAM531Jv8RZoHuhe5BcvF4PnqyoNFgX/QSTSdsVoa5AS1lG8f/tXKVr ggJbcqA42V+QWRS6ERsPHmRxo933LbI= X-Google-Smtp-Source: ABdhPJwkIqelHj0hSYc+TcOOM6T8oJatIR9f1zTPdfjqYGXzobDYLTfP6Ij70VXvCzdJcXxYqKTf3w== X-Received: by 2002:a19:50d:: with SMTP id 13mr19236752lff.443.1617695053424; Tue, 06 Apr 2021 00:44:13 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id w1sm2114569ljw.14.2021.04.06.00.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 00:44:12 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 1D0585601C4; Tue, 6 Apr 2021 10:44:11 +0300 (MSK) Date: Tue, 6 Apr 2021 10:44:11 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210402123420.885834-1-gorcunov@gmail.com> <20210402123420.885834-2-gorcunov@gmail.com> <4fdbd792-71a6-a19e-bf91-03902b22054a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fdbd792-71a6-a19e-bf91-03902b22054a@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v20 1/7] box/schema: make sure hashes are created X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Apr 05, 2021 at 05:45:54PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > I don't think this patch is needed, because it would crash anyway later, > if the hashes couldn't be allocated. On any of their usages. But > whatever. > > I also don't see how it is 'in scope of 4642'. It is completely > unrelated. So please, at least drop the reference. I filed a new bug https://github.com/tarantool/tarantool/issues/5967 and will address it separately later then.