From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A16A6EC5D; Tue, 6 Apr 2021 10:39:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A16A6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617694776; bh=kAnHPV95nqk014AkdMcjMJuK8DgSbbMsaZnV7pHVW0s=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=slDU50ePeDj4IENVCg4JNQBd+l6cv9f8+s6wrES0caxl1IryI/JD8uUQQOIfheYf4 phZVwC6BMumls8Y0QL10PVhDv1JXZc6U6U78AJ/WG54mK34tRFiFJjHci4675JX0xi qPKeXg+8E27H43oaku4mrvJS9Ao4Yn81YzvnGAw4= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B84CC6EC5D for ; Tue, 6 Apr 2021 10:39:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B84CC6EC5D Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1lTgJB-0001Tc-Km; Tue, 06 Apr 2021 10:39:34 +0300 Date: Tue, 6 Apr 2021 10:38:38 +0300 To: Igor Munkin Message-ID: References: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F5380850404E2707E4C262424685C03F4B5E623B60D24DEB877DB01B7F88BCCBA7670A8049 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE754E958D11587BC68EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637801520E8C0CFD3888638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6A7990D7032CF38E0D38C5BD56083CA13EA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7850F8B975A76562C9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BC468E7E89D8C5D6EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5850E7E938205B9ABDA7FA32AAA98473C1C6BDF99A820ECCCD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EB7BD66E9101C100A8210AF7788538EA0BF196DBBBAB9023003A48594021BF88D9B84793883E1E4D1D7E09C32AA3244C9DDF357B40B00FEF11DA5894C846F1B83E8609A02908F271FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0okXSqDg55FTjg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4051E0128B41945A64CAA4A3566BDBD4C13AF5EA626600DDAF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a few nits below. On 05.04.21, Igor Munkin wrote: Nit: I propose the following commit title rewording: | test: remove excess dependency for tarantool suite Feel free to ignore. > TEST_DEPS list was introduced to prevent target from > being run in case no dependencies are changed. As a result of review it Typo: s/result of review/result of the review/ > was decided to make all *-tests targets be .PHONY rules, hence TEST_DEPS Typo? "be" looks excess here. I propose the following rewording | As a result of the review it was decided to turn all *-tests targets | into .PHONY rules, hence TEST_DEPS variable is excess and can be | dropped. > variable is excess and can be dropped. > > Follows up tarantool/tarantool#4862 > > Signed-off-by: Igor Munkin > --- > test/tarantool-tests/CMakeLists.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index 9bb26f32..3e36ff86 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -69,7 +69,6 @@ set(LUA_PATH > ) > set(LUA_TEST_SUFFIX .test.lua) Nit: looks like `LUA_TEST_SUFFIX` variable is excess now, and we can move suffix ".test.lua" to `--ext` flag directly. Feel free to ignore. > set(LUA_TEST_FLAGS --failures --shuffle) > -file(GLOB TEST_DEPS ${CMAKE_CURRENT_SOURCE_DIR}/*${LUA_TEST_SUFFIX}) > > if(CMAKE_VERBOSE_MAKEFILE) > list(APPEND LUA_TEST_FLAGS --verbose) > @@ -78,7 +77,7 @@ endif() > # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list > # with dependecies are set in scope of BuildTestLib macro. > add_custom_target(tarantool-tests > - DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS} ${TEST_DEPS} > + DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS} > ) > add_custom_command(TARGET tarantool-tests > COMMENT "Running Tarantool tests" > -- > 2.25.0 > -- Best regards, Sergey Kaplun