From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 766276EC5D; Fri, 2 Apr 2021 11:48:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 766276EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617353319; bh=q7jkk9U5PL62FELHuh+J+mB5p8ynWfDSWUg9GRUivtA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F93w25OqtbjSSyBRJQdIpq2/nyIh233xrXFl2q6fvBZo5iiS59fs2Zo85Ow0wWrUO 7BYpxoqcKCwWH7uWxm9FQG/QVMUkPL8Ye7266tgcKTlrmNZnEexq+yu7i0W4NtWV0r i+TUlWwY950+s+c/6hNZ4pUEKlUZZ7SkGpr6EoFk= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D9536EC5D for ; Fri, 2 Apr 2021 11:48:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D9536EC5D Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1lSFTq-0003Tx-GB; Fri, 02 Apr 2021 11:48:38 +0300 Date: Fri, 2 Apr 2021 11:47:34 +0300 To: Igor Munkin Message-ID: References: <0e928a814f30027c58bcd7b6e587f811ed5a6dfc.1616743343.git.skaplun@tarantool.org> <20210331192448.GS29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192448.GS29703@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F538085040A1B3FE643595E1FBBE7964479A443AE16F2F45340A0CBA9DA30829E9EAF806C7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE793ECC5BC4DAF6EC5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FACF2191C0719DEE8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CFC956A2CA0FA98E041E788EB6D85CD524A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006372AAEE36821744B51EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B395F8F1267400161F6205099E5DCC7AFA888931C1296DF0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346B222596F62B8FA9A2E30F811ED465D2B73B396703C179AD1619A705C7576FE6B9ED6C17173445271D7E09C32AA3244C27DBCDBA8561F40C53AF005EB2F6B126795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf3352SWXH0QpBNQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4F25F6E4A8CA150901DC19784D270A1D12A11DB7365C42FD4F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 30/30] test: disable too depth recursive PUC Lua test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > The first Tarantool's fiber has only 512Kb of stack. > > It is not enough for depth recursive call in the test for > > Typo: s/depth/deep/. Fixed. > > > `string.gsub()`. > > > > This patch disables test leads to Tarantool crash. > > Typo: s/disables test/disables the test/. Fixed. > > > > > Relates to tarantool/tarantool#5782 > > Resolves tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun