From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 063CA6EC5D; Fri, 2 Apr 2021 11:46:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 063CA6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617353163; bh=g65zFi6RbbFI3wLsDnkfWfQMLgGprlmOvv9qf7jwWHQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Kse5ICLHgXJqdKezp+nEmylHOoiQr1kXgWPSE9oNMNi54eOTmrCX4OR0ns/DSyfZ1 GG2ppkLnAw0mzIOyPcBjzUK0YLi3QsxebhOpDAfk0yTP3trZIEzGo5nOlz4Ei3rumT C6/9OllyC2NqQhmPYjj/ooq4O+MWkeekEmnWOYr8= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D1AB66EC5D for ; Fri, 2 Apr 2021 11:46:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1AB66EC5D Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1lSFRJ-00032c-40; Fri, 02 Apr 2021 11:46:01 +0300 Date: Fri, 2 Apr 2021 11:45:06 +0300 To: Igor Munkin Message-ID: References: <20210331192437.GQ29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192437.GQ29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F53808504005774A8DFE61819E1A1147F3744B761E10B6B0FA09147F10083CD3DCC1ED79EF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CFAE1FBE7967B611585C29CD0D39386FEDA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5D990D75FA563215D7D05E15A55CBB185BAF1522BA137A524D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349A949488F6BF46DD4C8EDEA2436C3847E0DD54E8B9C0D68976460C252B5262B46C03B7C4BBB7A2061D7E09C32AA3244CF3BDA10303F957C2ACB0D18F27E1898CB038C9161EF167A1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf336FLfnGxvGXsg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4965EA441344626B270C8269D0D56587D80030145C609DABBF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 29/30] test: disable PUC Lua hanging GC test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > Tarantool has too many objects at start. `gcinfo()` result is always > > greater than 1000 expected by the test. It leads to infinite loop in the > > test. > > > > This patch disables GC test leading to hanging for Tarantool binary. > > Minor: I propose the following rewording: > | This patch disables GC test leading to Tarantool binary hang. Like it! Applied. > > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/gc.lua | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua > > index 072bbe9..7f9880f 100644 > > --- a/test/PUC-Lua-5.1-tests/gc.lua > > +++ b/test/PUC-Lua-5.1-tests/gc.lua > > @@ -133,9 +133,12 @@ do > > local a = {} > > until gcinfo() > 1000 > > collectgarbage"restart" > > - repeat > > - local a = {} > > - until gcinfo() < 1000 > > + -- Tarantool has too many objects at start. `gcinfo()` result > > I dare to guess that you're talking about *alive* objects here. Please > mention this explicitly, if I'm right. Added here and in the commit message. > > > + -- is always greater than 1000. > > + -- LuaJIT: The test is disabled for Tarantool binary. > > + -- repeat > > + -- local a = {} > > + -- until gcinfo() < 1000 > > end > > > > lim = 15 > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun