From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 78F316EC5D; Fri, 2 Apr 2021 11:40:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 78F316EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617352801; bh=Wh9+ezeimgMYLvC7RAHaz3I8cpNzepgiJraH7wxugxA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=G/M1G97wdxKvJY0cuBUWGbL1dWPsf4YDsDPoggBx1/Bdtjy22zOC8EFcIehanvApp aNhifgdmN/wI0BpUWN6zdfzICVOcDd27bbTZ+NC+O5dm/iorAT21Adah6ElxtKSM8Y YfUCVFL7zRTYnytuBkKNunjMAszRTKN2OwwOmq/Q= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3115D6EC5D for ; Fri, 2 Apr 2021 11:40:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3115D6EC5D Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1lSFLT-0000YN-Bk; Fri, 02 Apr 2021 11:39:59 +0300 Date: Fri, 2 Apr 2021 11:39:05 +0300 To: Igor Munkin Message-ID: References: <2500605f6727f2759acf18804c31f652f3108324.1616743343.git.skaplun@tarantool.org> <20210331192428.GP29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192428.GP29703@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F5380850403BF6B7707B8751CBE94EF6230F6B14F1255F1AE41291DC41B0FAF72A31C4A4B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CFB7B005F4787EEA24C5B17F89575BAAECA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E97D2AE7161E217F117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A57791711E0B24EBFB56B1AB6C3E3018723DFA741857BB86A2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34697E0FA301E28215E33D945FA7A3E4A83139C50F7009AD848E290480C298F0E87D25A30DC59FFF8C1D7E09C32AA3244C56EA62305096520BC1985AB601477496259227199D06760AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf336zoMgmoye+aQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB487587DD9BD6D6BDCA07E0C95AB976912557681D80CE42DD6F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 28/30] test: disable PUC Lua test checking -h option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. I see you added FIXME > here, so we can uncomment the test, if we separate LuaJIT regular > testing from Tarantool CI sometime... Yep, or will change Tarantool's behaviour. > > On 26.03.21, Sergey Kaplun wrote: > > Tarantool returns zero status at exit with -h option, unlike Lua or > > LuaJIT does. > > > > This patch disables test checking returning status, when binary > > Typo: s/disables test/disables the test/. > Typo: s/checking returning status/checking the exit code/. Fixed. > > > runs with -h option. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun