From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E77A46EC5D; Fri, 2 Apr 2021 11:36:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E77A46EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617352577; bh=8x4GtgLzZLR3az2b4G64M3nsVhoCUXc/cT2cmjjIk4o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=m7PtZkrPq4Ai4xEscCC3KUhkcSN7oOLRCEYwHmNNxNsmZskStd/7UBjkTDGo1Vpcl 7R0bT+rXg0VQ+vpjUQiPZ3NJjHlXiF4PAd4uFuRZhyTbQw66WJsGuKiQKjMeXvJnpP eOCizPxEBd3pSdBlbo/AvfZV9q6p9ayB1hL3ZsVk= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7E8A66EC5D for ; Fri, 2 Apr 2021 11:36:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E8A66EC5D Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lSFHr-0004sK-Qn; Fri, 02 Apr 2021 11:36:16 +0300 Date: Fri, 2 Apr 2021 11:35:21 +0300 To: Igor Munkin Message-ID: References: <20210331192418.GO29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192418.GO29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F538085040CAF8C5D3F99DD2CA8F841482387D9A3BC86B567F39C4036E6835D88798EF52BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D3219148F76DED538638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF10FF407B14B25BDBD3157279493CD7A7A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006374A4ED358074F063AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A563CE91EA917E57D3392F900EF5D9BB75EDCB84C53FED208DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A59E724FC7897F75B925D4C80C786D69C386D2369E145C01B7E1B100B607537772547E5519B68391D7E09C32AA3244CEC87EB18F5D48387AFF06D94A26562A34DBEAD0ED6C55A80FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf336WK7zGMcWJ3A== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB46708E6719C6C3ADADFF5AAE2EE896B57D6A59974CACA127AF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 27/30] test: disable PUC Lua test for checking arg layout X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the single nit. I see you added FIXME > here, so we can uncomment the test, if we separate LuaJIT regular > testing from Tarantool CI sometime... Yes, or even will make their behaviour the same. > > On 26.03.21, Sergey Kaplun wrote: > > Unlike LuaJIT, Tarantool doesn't store the given CLI flags in `arg`, > > so the table has the following layout: > > * arg[-1] -- the binary name > > * arg[0] -- the script name > > * arg[N] -- the script argument for all N in [1, #arg] > > > > This patch disables test checking `arg` layout by negative indexes. > > Typo: s/disables test/disables the test/. Fixed. > > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun