From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 327076EC5D; Fri, 2 Apr 2021 11:31:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 327076EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617352316; bh=c5ReiJmdZLlTQPkzh9XIa1wCrbQNJXghtnF3ojBk1L4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RnftuF8f5LCEyqSRFiQi5tlqWvWoejC5P6SNKhsIOYrZM/j1gRSOsJeSFfxiUsmRo X1b0SK6oREEJ3pbQ+7Pu+64L2wI28i2FoRW1wtCRE5TUXd0D0/OHQOkEpJP5ujX7L6 V6SgjhfL0sc17dp340yuKwMYAl9JCxr+RlkBbhpo= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C03DA6EC5D for ; Fri, 2 Apr 2021 11:31:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C03DA6EC5D Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1lSFDe-0008Uz-0Z; Fri, 02 Apr 2021 11:31:54 +0300 Date: Fri, 2 Apr 2021 11:30:59 +0300 To: Igor Munkin Message-ID: References: <20210331192405.GM29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192405.GM29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040CE52A7960A6474EB11B2B26003214E458769EE91D725A2F482959E7022A2C024 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB680D3A894950458638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF5F041F675020630A468120334F87F8C1A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A56B3DCDE3D9E31375E177FD3DFB270E56D31D4157840F883ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C9EDAD329B32B8368869FB427762D06FDAF253C75A71C13602D82D0ABA7B2323111D7E09C32AA3244CCDC4A534AD091E513FEA922EC30179C663871F383B54D9B3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf336/0p2T5VVeQw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB43A64E8F4A005B94E89FA3A92ED77D2E1E55EC2D6A14394DEF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 25/30] test: disable PUC Lua error test for syntax level X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review. On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > When LuaJIT is compiled with LUAJIT_ENABLE_GC64, LJ_MAX_SLOTS limit is > > reached and error LJ_ERR_XSLOTS ("function or expression too complex") > > is raised earlier, than LJ_MAX_XLEVEL limit is reached and error > > LJ_ERR_XLEVELS ("chunk has too many syntax levels") is raised. > > > > This patch disabled test expected the LJ_ERR_XLEVEL error, but > > Typo: s/disabled test/disables the test/. Fixed. > > > failing with the LJ_ERR_XSLOTS error. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/errors.lua | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > index 028224c..328976e 100644 > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > @@ -228,7 +228,13 @@ local function testrep (init, rep) > > end > > testrep("a=", "{") > > testrep("a=", "(") > > -testrep("", "a(") > > +-- LuaJIT: When compiled with LUAJIT_ENABLE_GC64, LJ_MAX_SLOTS > > +-- limit is reached and error LJ_ERR_XSLOTS ("function or > > +-- expression too complex") is raised earlier, than LJ_MAX_XLEVEL > > +-- limit is reached and error LJ_ERR_XLEVELS ("chunk has too many > > +-- syntax levels") is raised. > > Side note: It would be nice if you also mention the root cause. AFAIU, > LuaJIT frontend checks "virtual" stack size at the translation time, > right? Therefore, when GC64 support is enabled every call needs twice > more slots on the coroutine stack (since LJ_FR2 is also set). Added to the comment and the commit message. > > > +-- Test is disabled for LuaJIT. > > +-- testrep("", "a(") > > testrep("", "do ") > > testrep("", "while a do ") > > testrep("", "if a then else ") > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun