From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 361246EC5D; Fri, 2 Apr 2021 11:21:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 361246EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617351715; bh=Zc0q4J72EfUC4jkrV9USnS2HXXNVzam6FZCluSYlvw8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fDv4v42c7YN6avKi2UljdFG9ZeFZsc8dVKtRA8gW7GiNpI4fU2uP/u7V/fVq1eoiy EE/gUh7W4GWoFwOjAvvOVpNt6zknaiSmcwEzGOa8FPP2RHnueb26w1pJfy4ze3Lln0 DKKl+sWf8xZqyVaWuSsHWFgH8sOPkZSrmt89VqiQ= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 596656EC5D for ; Fri, 2 Apr 2021 11:21:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 596656EC5D Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1lSF3x-0000ZB-Kq; Fri, 02 Apr 2021 11:21:54 +0300 Date: Fri, 2 Apr 2021 11:20:59 +0300 To: Igor Munkin Message-ID: References: <20210331192357.GL29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192357.GL29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F5380850409B63973984D972F1EF1F0DE8A49CD92B1A2E2C3220CD08012277F76A60DC9616 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770995E888C5C26978638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CFB7FC6491D60568F89A317F77E447C80AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77FFCE1C639F4728C9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FF021744A2531FDDCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7325B7099C10CC3D7731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5599A0ECF04400CDFEFF926EB7962EE1E47C1C5C28EAD39FAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF137708F976857538377255A5D3E9C50E1D9C8578D0E2DD8A3A73AA5ADE500CA9F1D7E09C32AA3244C2AD11630321181586CD794723A547507435BF7150578642FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf335HYtUlN9Zc3Q== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB431909002BF1DC70F972FDB044B3AE4C6D1E700247102C3F7F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 24/30] test: disable PUC Lua test for non-asci identifier X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT does not avoid to use non-alphanumeric symbols as identifiers, > > Typo: s/avoid to use/forbid using/. Fixed. > > > unlike Lua does. > > > > This patch disables test that expects an error during parsing variable > > Typo: s/disables test/disables the test/. > Typo: s/parsing variable/parsing the variable name/. Fixed. > > > contains octal \255 as the first char in a variable name. > > Typo: s/contains/containing/. Fixed. > > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/errors.lua | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > index af776a7..028224c 100644 > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > @@ -202,7 +202,11 @@ checksyntax("[[a]]", "", "[[a]]", 1) > > checksyntax("'aa'", "", "'aa'", 1) > > > > -- test 255 as first char in a chunk > > -checksyntax("\255a = 1", "", "\255", 1) > > +-- LuaJIT does not avoid to use non-alphanumeric symbols > > Typo: s/avoid to use/forbid using/. Fixed. > > > +-- as identifiers, unlike Lua does. > > +-- For more details see and . > > +-- LuaJIT: Test is disabled for LuaJIT. > > +-- checksyntax("\255a = 1", "", "\255", 1) > > > > doit('I = loadstring("a=9+"); a=3') > > assert(a==3 and I == nil) > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun