From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 29EFA6EC5D; Fri, 2 Apr 2021 11:15:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 29EFA6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617351354; bh=QOCqAHn4UFfQJjY6T+Kx+u+xPsON84+Rqmf4ORwmVhY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UpjAjaSBLdDQkhC0D7dZ/vu/gOgtDHY9sOkidLR75wlkFzzI66WF++3ij+r/Ez2FF dN/ajDvOFPS2gJAx2jBn5JnZLgPigiK+ZiCKe3uRCvrsscAzl2buN82bPPPitosOzF 6zy4K8VlRvazpQ54/Vyzw9Dt3K3t/FcDJHUHCFyE= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BB7E56EC5D for ; Fri, 2 Apr 2021 11:15:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB7E56EC5D Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1lSEy7-00077e-Ul; Fri, 02 Apr 2021 11:15:52 +0300 Date: Fri, 2 Apr 2021 11:14:12 +0300 To: Igor Munkin Message-ID: References: <20210331192350.GK29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192350.GK29703@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F538085040575E193D46C266FE86FA5570C80EA57BB627C0FE5E33CCD2536586A757362A10 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063771C846A5973DEE7E8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF202B2A4C0A5C02BDF4C5CE69826E10CAA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C37EF884183F8E4D67117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5A2D2E9F88F93EC7146AC557D1E08976F45DD8084FF89876DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342F9EE325F82A28A80B5BBE5BA3D855CAEDD6EFD253159A02AEE19CBF87F0A6B72159EB3CB8FBC67D1D7E09C32AA3244C5BF341717BB9E9A56953B6B2A6DB7894250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf337ewDeOKlUolQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB44CC5B71AABCBC2378F40CAF4B6075E5D00255F0BA0C54D1FF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 23/30] test: disable PUC Lua test for fast function name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider the comments below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT can't determine bytecode position for non Lua functions > > (in particular for fast functions) and, therefore, detect built-in > > function names for errors in tail calls. > > Side note: here is the inconsistency in your usage of possessive nouns. Fixed. > > > > > This patch disables test that checks name of built-in functions > > Typo: s/disables test/disables the test/. > Typo: s/checks name/checks the name/. Fixed. > > > reported in error in tail call. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/errors.lua | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > index cf24e40..af776a7 100644 > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > @@ -105,9 +105,13 @@ while 1 do > > insert(prefix, a) > > end]], "global 'insert'") > > > > -checkmessage([[ -- tail call > > - return math.sin("a") > > -]], "'sin'") > > +-- LuaJIT: Can't determine bytecode position for non Lua functions > > +-- (in particular for fast functions) and, therefore, detect fast > > +-- function names for errors in tail calls. > > This is kinda gibberish. I've tried the following snippets and can't > understand what do you mean by this comment. > > | $ luajit -e 'function q(a) return math.sin(a) end q("a")' > | luajit: (command line):1: bad argument #1 to 'q' (number expected, got string) > | stack traceback: > | [C]: in function 'q' > | (command line):1: in main chunk > | [C]: at 0x5610e8497eb0 > | $ luajit -e 'loadstring("return math.sin([[a]])")()' > | luajit: (command line):1: bad argument #1 to '?' (number expected, got string) > | stack traceback: > | [builtin#43]: at 0x7fc0f807ad10 > | (command line):1: in main chunk > | [C]: at 0x55c1e85c7eb0 > > I understand the first result. The second result surprised me, but I've > never investigated how loadstring call works (it looks like specifics of > VARG frame, but this is a wild guess). But neither of them fits your > explanation. The root cause is the same: callee uses caller frame, since > caller doesn't need it anymore. Could you please clarify yours? This is not about `loadstring()` at all: | luajit -e 'return math.sin"a"' | luajit: bad argument #1 to '?' (number expected, got string) | stack traceback: | [builtin#43]: at 0x7f7c2ca6dbe0 | [C]: at 0x558b0cd4cec0 The guest frame is looked like the following (when the error thrown): | 0x40001938 [ ] VALUE: string "number expected, got string" @ 0x40008380 | 0x40001930 [ B ] VALUE: string "a" @ 0x40008250 | 0x40001928 [ ] FRAME: [CP] delta=3, fast function #44 When LuaJIT tries to detect function's name it determines bytecode position first, via `debug_framepc()`. But it can't determine bytecode position for non-Lua functions: | if (!isluafunc(fn)) { /* Cannot derive a PC for non-Lua functions. */ | return NO_BCPOS; > > > +-- The test is disabled for LuaJIT. > > +-- checkmessage([[ -- tail call > > +-- return math.sin("a") > > +-- ]], "'sin'") > > > > checkmessage([[collectgarbage("nooption")]], "invalid option") > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun