From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 26A3F6EC5D; Fri, 2 Apr 2021 10:49:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 26A3F6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617349742; bh=Vj2Dv4uCXP37zg5EcScdmDbn5W2CCO4emEaTBLRfNsE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uVdMXUVs4imvpkvKuQUBxU2MkB5Z3cd04PcRIGKU0dOrU/0ZvILU8OVQ5X9DrUOBw kkw7Ud/T1fIaa1y5msIDMYZFC+G8Bu3zPaYJFtnMSmOBGB2IbG+XhgmNlX5ZaJPsiy 7nh7Yf+2Pf//nnrev/wOhg0V2/EUxJWUf3xA6N7Y= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E12B6EC5D for ; Fri, 2 Apr 2021 10:49:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E12B6EC5D Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1lSEY7-0005ir-MF; Fri, 02 Apr 2021 10:49:00 +0300 Date: Fri, 2 Apr 2021 10:48:05 +0300 To: Igor Munkin Message-ID: References: <20210331192338.GJ29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331192338.GJ29703@tarantool.org> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709C5527BBE40F25C64182A05F538085040C86FA4749F67426C011EAD0321584B4B3F329717F10D96CC36C85F6521C0E975 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370D3D68FCEFFDD9EA8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF41AD6904E5C0DFA10D0CBEA8C4C4745BA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657AAAE862A0553A39223F8577A6DFFEA7C468D16C903838CAB43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978317CB25F3DE823AC2249269A4754B3489E X-C1DE0DAB: 0D63561A33F958A5AF05197F9901D8EDB8CDC0592EEF19A98CCEE8007AFF7707D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34060C3C6DE316ECE48AFC9F09A9E181721C20F3D068B0FBD492FBEDE47D42FB57B2CB089BB5CDD23E1D7E09C32AA3244C8693295A0425F8EF4E06AE64CF1F381835DA7DC5AF9B58C0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf3340WqCoD2wmxw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB47BB002BF61975F8750CB9D725B3D914608F7B0F3057325AFF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 22/30] test: disable PUC Lua test for var names in error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT includes variable name to the error report, when try to > > Minor: "error message" is more correct than "error report" here. Fixed. > > > call non-function object without __call methamethod. > > Typo: s/methamethod/metamethod/. Fixed. > > > Also, LuaJIT includes variable name to the error report, when try to > > Typo: s/includes variable name/includes the variable name/. Fixed. > > > perform unacceptable arifmetic operation with the variable. > > Lua 5.1 doesn't report variable name in these errors. > > > > Test ckecked that variable name aren't reported are disabled by > > Typo: s/Test checked/Tests checking/. > Typo: s/name aren't reported/name isn't reported/. Fixed. > > > this patch. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/errors.lua | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > > index e881211..cf24e40 100644 > > --- a/test/PUC-Lua-5.1-tests/errors.lua > > +++ b/test/PUC-Lua-5.1-tests/errors.lua > > @@ -72,8 +72,13 @@ checkmessage("b=1; local aaa='a'; x=aaa+b", "local 'aaa'") > > checkmessage("aaa={}; x=3/aaa", "global 'aaa'") > > checkmessage("aaa='2'; b=nil;x=aaa*b", "global 'b'") > > checkmessage("aaa={}; x=-aaa", "global 'aaa'") > > -assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > > -assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > > +-- LuaJIT: LuaJIT includes variable name to the error report. > > Minor: "error message" fits better than "error report". Fixed. > > > +-- It looks like: > > +-- "attempt to perform arithmetic on global 'aaa' (a table value)" > > +-- Lua 5.1 doesn't report variable name here. > > Typo: s/report variable name/report the variable name/. Fixed. > > > +-- Tests are disabled for LuaJIT. > > +-- assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > > +-- assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > > > > checkmessage([[aaa=9 > > repeat until 3==3 > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun