From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E86EE6EC5D; Fri, 2 Apr 2021 10:06:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E86EE6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617347181; bh=tWZ9WMws44/f6YAwEIISHpHUWqYgS4CNozHoEDfkutM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ALYGsR7zJ7LvfFdRlDvfdzthaw16lWnBmoCv1yRhlSVKihvl5RZKaplFfF7Hb8CnP X/DOgAWZaicWFCR8mUxwz64NHu+w6zwzs5XlMixW9L2pX952QRb6SU/U7V+NJwv2F/ sHQ1WxVdMGTaqrRPu3EVp8XPEm/IE/efM6X3Qf2w= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6935E6EC5D for ; Fri, 2 Apr 2021 10:06:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6935E6EC5D Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lSDso-0000Fw-76; Fri, 02 Apr 2021 10:06:18 +0300 Date: Fri, 2 Apr 2021 10:05:23 +0300 To: Igor Munkin Message-ID: References: <946be811cd2557fb65459c0de499cdc62229fdd6.1616743343.git.skaplun@tarantool.org> <20210330221724.GE29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221724.GE29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F5380850401F8787146330308DAFDD9EDBC2E87DB322931C664B5BABA85DA721BF6DDFFA18 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7D3E352D4AD7EBF54EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664549415D210136967256ADE2D3EB0E279386BB02F42762D8E389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE77F0BEB5BCCFF2072731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A55F781E759F513F639EEBF2F467D0B2EDB0B4F9945DDB0F88D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3451BBE684D17D7221F577F22D85312347F66E3552A5AA6C64C9F8937767700A42BD66CE7D794FF65C1D7E09C32AA3244CD04DF6676F2F805880AA044070EE0BB6CE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf335SSevjAd+v5w== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB44B4362E9D0468E1200B08FC3F29D2AAD5B2EE8FE1AE1B635F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 19/30] test: remove assert for string.gfind check X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the single nit. > > On 26.03.21, Sergey Kaplun wrote: > > In Lua 5.1 function `string.gfind()` was renamed to `string.gmatch()`. > > You can use it if Lua 5.1 is built with compile-time option > > `-DLUA_COMPAT_GFIND`. > > This built-in is removed from LuaJIT. > > Please mention the patch[1] where this builtin is removed. Done. > > > > > This patch removes test checking that `string.gfind()` and > > `string.gmatch() is the same function. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/pm.lua | 1 - > > 1 file changed, 1 deletion(-) > > > > > > > -- > > 2.31.0 > > > > [1]: https://github.com/tarantool/luajit/commit/de5568e > > -- > Best regards, > IM -- Best regards, Sergey Kaplun