From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 71BF56EC60; Thu, 1 Apr 2021 22:37:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 71BF56EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617305875; bh=1zCo1OzvBdNThxkjJsBIR07G00YWuzYvn2YcZOU3bL8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Qu109mzJADIJp9dSu/ZjGAupuWHM5nOcENfgdQRnwhB1jPUdH9F4R0ev08qBHb0TT loHouyHcBSQegljwyqqtS2dkeoYovpnd8uSOrFjWdxiFI9CZ6xqieHp9iXow8IGTco 3J3Vuy39CN3F6LBL2sST+EYqpJJ7FJ01eUMk8kyI= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 24D2C6EC60 for ; Thu, 1 Apr 2021 22:37:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 24D2C6EC60 Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1lS38b-00042t-BU; Thu, 01 Apr 2021 22:37:53 +0300 Date: Thu, 1 Apr 2021 22:36:59 +0300 To: Igor Munkin Message-ID: References: <2ffe160c0e47930914ff03996df38af1d9625767.1616743343.git.skaplun@tarantool.org> <20210330221657.GC29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221657.GC29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F538085040B71982DCED28FD07279B103E353DE2E1EAABD655880352CD6B7C05AC1B415931 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6702EC5472AA0FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF2F0C3D43ACF626505C6AAD1706D7C57CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C353FA85A707D24CADCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7B18213328BEF0AF1731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5360785B38EFC31E9247528D086F8B44DB834CCBC4D55A1D8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454548929AF40B428B303FD89610DF5BFFB7F8D0C0828B3AD6342BD69C68A3D0E46E4D6D716D5DE831D7E09C32AA3244CD7DAD9BDD8E9FB39FAAD224B36D49013408A6A02710B7304FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf3363uphGjMxGdQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB42EC27821F1032DD16F8C2CE9EE7A02BF3DCE99E73093D3FCF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/30] test: replace math.mod to math.fmod for Lua tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > There is a typo in commit subject: > s/replace math.mod to math.fmod/replace math.mod with math.fmod/. Fixed. > > On 26.03.21, Sergey Kaplun wrote: > > In Lua 5.1 math.mod() is renamed to math.fmod() if build Lua 5.1 without > > Typo: s/if build Lua 5.1/if Lua 5.1 is built/ or > s/if build Lua 5.1/if one build Lua 5.1/. Fixed. > > > flag `-DLUA_COMPAT_MOD`. > > Typo: s/flag `-DLUA_COMPAT_MOD`/`-DLUA_COMPAT_MOD` flag/. Fixed. > > > LuaJIT has math.fmod() instead old-style math.mod() built-in. > > Typo: s/instead old-style/instead of old-style/. Fixed. > > You can also mention the commit[1] where this is done. Done. > > > > > This patch replaces usage of math.mod with new-style math.fmod > > in the following files: > > * closure.lua > > * constructs.lua > > * math.lua > > * nextvar.lua > > > > Closes tarantool/tarantool#5711 > > As we discussed before: s/Closes/Resolves/. Fixed. > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/closure.lua | 3 ++- > > test/PUC-Lua-5.1-tests/constructs.lua | 6 ++++-- > > test/PUC-Lua-5.1-tests/math.lua | 3 ++- > > test/PUC-Lua-5.1-tests/nextvar.lua | 3 ++- > > 4 files changed, 10 insertions(+), 5 deletions(-) > > Typo: s/instead old-style/instead of old-style/g in all chunks. Fixed. > > > > > > > > -- > > 2.31.0 > > > > [1]: https://github.com/tarantool/luajit/commit/de5568e > > -- > Best regards, > IM -- Best regards, Sergey Kaplun