From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 317846EC60; Thu, 1 Apr 2021 22:13:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 317846EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617304431; bh=y1SVzrN61/ppAt0SH/0kLC7cTubA0y5NunLCpGuWi8w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PtwBiyCIvkFzRlInQW+dxZ/317xj7oeqeTAeqRG3meO3GK4SED0Hh3dbSW8ZWNNLF ra47qjjOf6DDx3JBMkVyviCdOVF8qIAdegg+1wtY1heptiah0OxxmSC5rZ1HvEeFsh 4OL4LjdsjdvHaExQG5jNXTvGJEqvJ1q237xZNoRw= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3F34A6EC60 for ; Thu, 1 Apr 2021 22:13:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3F34A6EC60 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lS2lI-0007fL-8I; Thu, 01 Apr 2021 22:13:48 +0300 Date: Thu, 1 Apr 2021 22:12:53 +0300 To: Igor Munkin Message-ID: References: <86ead4f35be1f65e9e4c0e46715d42a05851ba6d.1616743343.git.skaplun@tarantool.org> <20210330221641.GB29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221641.GB29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040780BE9B0F14A7129EB04879DA667887948B5A1CD3FE84F4762B0962BFECD1354 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063732727FD5A4355FD18638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7B5A45DDF210A4CF136C13C0E8A91C264E27CC603D2587A2A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7850F8B975A76562C9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637ADC6BCC4AC6AF740EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A528512ABBB5F1493EBD262A778BEBCABA2146832FBBD29871D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA13E2DDB90678627BC4D45785F1C3C27744665D5F2691AFDF643B10D971C3D831FF7D13001CADF71D7E09C32AA3244C189960FE6780920FA33977BC02C1A4EE81560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiysexgWf3368waOk0F2soA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4493065D11C385D885D26D69E1E0B9FB6671F586327DBD068F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 17/30] test: disable locale-depended tests for Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT doesn't compare strings by `strcoll()`, like Lua 5.1 does. > > So locale-depended tests in are disabled. > > Side note: unfortunately, this is not mentioned anywhere except the > sources... Classic. > > > > > Also, LuaJIT doesn't use `strtod()` depended on the locale for parsing, > > Typo: s/depended/dependent/. Fixed. > > > unlike Lua does. See for more info. > > Locale-depended tests in are disabled. > > Minor: Please, refer the docs[1] or the patch[2] changing the behaviour > in the commit message. Refered docs. > > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/literals.lua | 5 +++++ > > test/PUC-Lua-5.1-tests/strings.lua | 5 +++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/test/PUC-Lua-5.1-tests/literals.lua b/test/PUC-Lua-5.1-tests/literals.lua > > index 01d84d5..1b4f664 100644 > > --- a/test/PUC-Lua-5.1-tests/literals.lua > > +++ b/test/PUC-Lua-5.1-tests/literals.lua > > @@ -158,6 +158,10 @@ end > > > > > > -- testing decimal point locale > > +-- LuaJIT: LuaJIT doesn't use `strtod()` depended on the locale, > > Typo: s/depended/dependent/. Fixed. > > > +-- unlike Lua does. See for more info. > > +-- Tests are disabled for LuaJIT. > > +--[[ > > if os.setlocale("pt_BR") or os.setlocale("ptb") then > > assert(tonumber("3,4") == 3.4 and tonumber"3.4" == nil) > > assert(assert(loadstring("return 3.4"))() == 3.4) > > > > > -- > > 2.31.0 > > > > [1]: http://luajit.org/extensions.html#tonumber > [2]: https://github.com/tarantool/luajit/commit/4c882fe > > -- > Best regards, > IM -- Best regards, Sergey Kaplun