From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B98606EC60; Thu, 1 Apr 2021 14:43:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B98606EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617277432; bh=hvA6yntt6/ON2UwqQfUF/4Db3e8V/0bE44my/S0NUyA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EpaRW0mZFXjqook6WbAn+Uyckq8WA2RJceO4wL8ucU//cIPWFW2vUDHrc4HoiWCXy lYW/jPCN8yNZTO7v+g4zBxsUMSYbaGvBYgSQZH9GUqKOfG6taYqbXlaKoc7que+9QV 3qAIaC4sJRRJ6JzFqCo9lOYSKQUaGDbDdJJ1DNtk= Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FC2A6EC60 for ; Thu, 1 Apr 2021 14:43:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FC2A6EC60 Received: by smtp17.mail.ru with esmtpa (envelope-from ) id 1lRvjq-0000Yb-D7; Thu, 01 Apr 2021 14:43:50 +0300 Date: Thu, 1 Apr 2021 14:42:45 +0300 To: Igor Munkin Message-ID: References: <20210330221521.GW29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221521.GW29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040F45A3D0060DD3F8062D009E724823E23663656B95EC68149C6E662B34E2190E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D58C44ED3182E498638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF766A0293DC35F38B5769C9F7FC79E35AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5768EAD27DD23764F7BEC8753E9533ABF7DF5B8790CCCD798D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A5BF8FA0BD61F9940B53D9A7CF423AD376386267EF84DBC08BBC05D233390B11D295725E55B3928F1D7E09C32AA3244C0765CE4D1BDE8B7530DA22EA08216196F94338140B71B8EEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20KMWFck0okpxQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4CB9DCED6F56A4E060B9E714D406248B6D59B17FE7AEF02ABF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 12/30] test: adapt PUC Lua test with count hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the single nit below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT does not check hooks at traces without defined > > -DLUAJIT_ENABLE_CHECKHOOK. For more information see > > or commit 6bce6b118eeb2bb7f36157de158e5cccf0ea68e5 (Add compile-time > > option LUAJIT_ENABLE_CHECKHOOK. Disabled by default.). > > > > This patch adapts these tests for LuaJIT by disabling JIT while testing > > count hooks. > > > > Closes tarantool/tarantool#5701 > > As we discussed before: s/Closes/Resolves/. Fixed. > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun