From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ED3156EC60; Thu, 1 Apr 2021 14:38:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED3156EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617277124; bh=ZocPOgckzsO4lLmrNJb/p9tXQZsuXZzKGBJ8kLdrHxE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t4i4ymY0Xj6DXXkYeaWM4A2sYC5wdKiHwRZ28KBn76Hlo34Ncw1Dvf4juE8P1nNOr m6CKefqRblUoN57lO5J0rT195tKe695oG7GuDdL0ryimokF96Gy1aR+HuLMq/GiG6U wlyIrC1ZsxSF26kCGSDd63i8oNKE+irTX/Zi8974= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 91B136EC60 for ; Thu, 1 Apr 2021 14:38:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91B136EC60 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lRves-00008u-Kl; Thu, 01 Apr 2021 14:38:43 +0300 Date: Thu, 1 Apr 2021 14:37:48 +0300 To: Igor Munkin Message-ID: References: <0bf0dc418d1095fc5c8d3901469662c853fb93de.1616743343.git.skaplun@tarantool.org> <20210330221506.GV29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221506.GV29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F53808504017A82BB74145477D95890023DB3768855B7703264D851E37C778B5D081473902 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376AFB9B40001E44068638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFD07CE515A7C47ADF488FB67BF876EFA4A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783183071FD6ABDC5EC3B24383D33A8A987E X-C1DE0DAB: 0D63561A33F958A518E6C2BDC34C502C572C3167EE98376BAFE27E192A50B393D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3419891600CCEF46075802B45E08471D99DE9A6E5D701C7410EC7D825B44EF98CDC631977059C4F1CA1D7E09C32AA3244CC5FAA42375A6BA2677B14D7547F97114250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20LtdkjWT8SbdQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4429B6EEA6195ED73A5897FCCD9DB4547DBC905541AEF4839F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/30] test: adapt getlocal PUC test for vararg func X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! I can't understand why this patch is separated > from the previous one. Could you provide a rationale for this, please? > BTW as we discussed before: s/Closes/Resolves/, considering your changes > on the branch. Also consider the comments below. The root reason of the previous patch is about counting of local variable in caller. Here this local variable is used for counting arguments amount. > > On 26.03.21, Sergey Kaplun wrote: > > Lua 5.1 interprets `...` in the vararg functions like an additional > > Typo: s/like/as/. Fixed. > > > first argument unlike LuaJIT does. So, `a:f()` function will not set > > corresponding table `arg`, as test expects. > > Typo: s/set corresponding table `arg`/set the corresponding `arg` table/. Fixed. > > > > > Implicit `arg` parameter for old-style vararg functions was finally > > removed in Lua 5.2. The test is adapted from PUC-Rio Lua 5.2 test suite > > by removing additional check for amountt of arguments via `arg.n`. > > Typo: s/amountt/amount/. Fixed. > > > Lua 5.2 test suite is taken from > > https://www.lua.org/tests/lua-5.2.0-tests.tar.gz. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/db.lua | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > > index e5d8885..6985c29 100644 > > --- a/test/PUC-Lua-5.1-tests/db.lua > > +++ b/test/PUC-Lua-5.1-tests/db.lua > > @@ -300,7 +300,16 @@ debug.sethook(function (e) > > > > > +-- LuaJIT: Lua 5.1 interprets `...` in the vararg functions like > > Typo: s/like/as/. Fixed. > > > +-- an additional first argument unlike LuaJIT does. > > +-- So, `a:f()` function will not set corresponding table `arg`, > > Typo: s/set corresponding table `arg`/set the corresponding `arg` table/. Fixed. > > > +-- as test expects. > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun