From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F63C6EC60; Thu, 1 Apr 2021 13:17:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F63C6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617272268; bh=dqH59c3PVcoBpn/K5Q51QSIMIzrs0CstWtRa73o3RTI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=o2RFEcX3V3NbaGv/bkMVzQA1x12tBKSrL1898+Kf4zwSDkjTcxkR9EZh5mfRUrAyQ 3jUb13T8CgjEkX+Nm2WJPGvx7Tgxg8oaE585Jk5iyabkCFrKKQgRxlaxo1yzLn6Td0 XPgoYy1Mi/DuN3ljXSKHb4MOleedUPBYy5aaYSH4= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1EA306EC60 for ; Thu, 1 Apr 2021 13:17:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1EA306EC60 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1lRuOW-0007Xb-3C; Thu, 01 Apr 2021 13:17:44 +0300 Date: Thu, 1 Apr 2021 13:16:49 +0300 To: Igor Munkin Message-ID: References: <2a4f7f1c49f5c9c0ffd1a512d809588f7a7694db.1616743343.git.skaplun@tarantool.org> <20210330221439.GU29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221439.GU29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040BD7D6569C343E696E4148945DABF5522692DFC68B59E069DAEFF3AC8484C4FF7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374D0D183F14C070BA8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF00E5B05E31F240D55D49917023AE378BA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6A70DDFFB3186CBC5CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7318833E8B5F68F51731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5459FFE23814B899CE86F40370DF4AC9840A43B82D2D2C72BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349320586B19AD2C725D733CEEF54533014EBF9CC6E0834A1EDDCAB21F18BACE1132C7579657C440B11D7E09C32AA3244C2CC4971077427E920A445C84AAF87D8795A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20KFQiRh7G0Vug== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB43260ADF402D650EC4419EA4593DF4F18058B4CC93B12BFF9F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 10/30] test: adapt test for debug.setlocal in Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, considering your changes on the branch. Also > consider the comments below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT: Lua 5.1 interprets `...` in the vararg functions like > > Looks like you just copied the comment below. There is no need for > 'LuaJIT:' here. > > > an additional first argument unlike LuaJIT does. > > This behaviour is extension is from Lua 5.2. > > Typo: s/is extension is/is extension/. > > > > > This patch adapted test considering LuaJIT's and Lua 5.2 behaviour. > > Side note: Here it is -- you wrote LuaJIT's but Lua 5.2 (neither Lua's > 5.2 nor Lua 5.2's). How come? > > > The test is adapted like it done in Lua 5.2 test suite taken from > > https://www.lua.org/tests/lua-5.2.0-tests.tar.gz. > > > > Closes tarantool/tarantool#5694 > > As we discussed before: s/Closes/Resolves/. > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- The new version of the commit message: =================================================================== test: adapt test for debug.setlocal in Lua suite Lua 5.1 interprets `...` in the vararg functions like an additional local argument unlike LuaJIT does. This behaviour is extension from Lua 5.2. This patch adapted test considering behaviour of LuaJIT and Lua 5.2. The test is adapted like it done in Lua 5.2 test suite taken from https://www.lua.org/tests/lua-5.2.0-tests.tar.gz. Part of tarantool/tarantool#5694 Part of tarantool/tarantool#5845 Part of tarantool/tarantool#4473 =================================================================== > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun