From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 497B46EC60; Thu, 1 Apr 2021 13:11:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 497B46EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617271914; bh=RcNUWCb1v1QOV5PJStTQ1mghMJMd7XJjNXqs5E6w3lI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XO1jGYbL5sPhw+pdc/svLg2Bu0zYZsdCtILuund6HWXLevR1JoUI+YMt6FRLFem5i D9wox1iE2TBQUqB5FcPT8dRC5NB59ud0EE4e+19S8qSwncNOh3qcVklq2xGNFXQpSI WIQisMdI6QwqoOtQo+aWCknFUuAMJFxNKzdaULEU= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 775736EC60 for ; Thu, 1 Apr 2021 13:11:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 775736EC60 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1lRuIq-0000Ci-Pc; Thu, 01 Apr 2021 13:11:53 +0300 Date: Thu, 1 Apr 2021 13:10:57 +0300 To: Igor Munkin Message-ID: References: <20210330221422.GT29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221422.GT29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040646AF8E55FA2BF42800ED9B64FFEFDDC8850FDA9A6666FBBA3574A25B92D4EE8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70C5E0F71D77D667BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770995E888C5C26978638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF2C7B6E48099AACB2363065CD9267BCCAA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5C80E163781EA47F3BCB322FEAC9150430441B2C3B9D15F99D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3475FE4AA98865E2359CFFC9CE9A7DCDBB04EBF33BA063FBCBC216B48E87E8D1E202E99FAA41586A451D7E09C32AA3244CD4DD9878F12B57803E29EA0A1B30ACC9A8CE788DE6831205FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20LyhZ6WU/PNtA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB468DC541F55A867C863D7F93FE9987F7ADA8AFC00E9F04ACCF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/30] test: disable JIT for GC step counting tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > I propose the following rewording for commit subject: > | test: disable JIT for the tests counting GC steps Thanks, applied! > > On 26.03.21, Sergey Kaplun wrote: > > JIT compilation can unpredictable allocate or reference objects (or > > Typo: s/unpredictable/unpredictably/. Fixed, thanks. > > > traces itself). So, the amount of GC steps can vary from run to run. > > > > This patch disables JIT machinery, if it is enabled, for stable GC > > results. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/gc.lua | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua > > index 86a9f75..072bbe9 100644 > > --- a/test/PUC-Lua-5.1-tests/gc.lua > > +++ b/test/PUC-Lua-5.1-tests/gc.lua > > @@ -108,11 +108,21 @@ local function dosteps (siz) > > return i > > end > > > > +-- LuaJIT: JIT compilation can unpredictable allocate or reference > > Typo: s/unpredictable/unpredictably/. Fixed. > > > +-- objects (or traces itself). Disable it if necessary for > > +-- this chunk for stable GC results. > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun