From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 32A956EC60; Thu, 1 Apr 2021 12:57:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 32A956EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617271060; bh=j73XfCecje+n/O/Ti2fBFgHir4oeKCDsTcBRmpK2R9M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=x//9saJ6BYqMYgaVB1B33HX3KVZNkX8hRQdioIi9Lii78a/SXNJ9KuLmHo2Zuc5LK dB3cfLJ1XsJQOyQm/QA637gd1mfTLTqsfM+wHf9QUbCnKRQ9EhyKiCVFRRPamwn17s 4AvYkqhCfT8O/fFImuo0Wkep6Kx3D8bfhXOc69u4= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CEA266EC60 for ; Thu, 1 Apr 2021 12:57:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CEA266EC60 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1lRu52-0002fF-V4; Thu, 01 Apr 2021 12:57:37 +0300 Date: Thu, 1 Apr 2021 12:56:42 +0300 To: Igor Munkin Message-ID: References: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> <20210331225857.GX29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331225857.GX29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040CAB730360EF9BC5E971E841AB35E8B653ED739706869EF74386EE8D68A9CB369 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFB121EBB473100B1B25A49E0F6E017D91A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637ADC6BCC4AC6AF740EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5FD5C896215C8C6FB1899F7B9A3E31CE544D646BC35752305D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3414C91BA6844B96CAE14E00D04DC46ACE84D8B21B385E8BB83B7875DD192131F3578D1B16F32124071D7E09C32AA3244C937A0B97524709FEC8E133D2BE771A267101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20KypW3kq6X95Q== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB473E772FD3BF2AD0387E34667FB2F17E0FF527B14F8541A2EF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/30] test: disable PUC Lua tests confused by -v output X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 01.04.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > Version and status are printed in stdout instead stderr since > > Typo: s/printed in stdout/printed to stdout/. > Typo: s/instead stderr/instead of stderr/. Fixed. > > > LuaJIT-2.0.0-beta11 (as it is not an error message). > > See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > > (Print version and JIT status to stdout, not stderr.). > > This behavior is the same as in Lua 5.2. > > > > This patch disables tests confused by unexpected -v output to stdout. > > > > Relates to tarantool/tarantool#5687 > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/main.lua | 28 ++++++++++++++++++++-------- > > 1 file changed, 20 insertions(+), 8 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > > index c11a576..56f56a0 100644 > > --- a/test/PUC-Lua-5.1-tests/main.lua > > +++ b/test/PUC-Lua-5.1-tests/main.lua > > @@ -103,26 +103,37 @@ prepfile[[ > > RUN("lua - < %s > %s", prog, out) > > checkout("1\tnil\n") > > > > +-- Version and status are printed in stdout instead stderr since > > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). > > Typo: s/printed in stdout/printed to stdout/. > Typo: s/instead stderr/instead of stderr/. Fixed. > > > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > > +-- (Print version and JIT status to stdout, not stderr.). > > +-- This behavior is the same as in Lua 5.2. > > +-- In Lua 5.2 this feature was introduced via commit > > +-- 9e7de9473c65baee1f567852a778f2d33a47ea83. > > +-- See also https://github.com/tarantool/tarantool/issues/5687. > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun