From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 546F66EC60; Thu, 1 Apr 2021 12:38:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 546F66EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617269931; bh=2AWMd3U4mWBKF0kjNVwNABd9pbQJEnvCsV5fqy4zopM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YXol4NsWmSZnzi3AOgWTJwynWg+Z0cpdRLRHpmgAxjAvX518Ric0VpnvjkMYTHirn TUSbMupzQEFv44mlDfBQ5FD97o2n1K3B7RlQTUwcLHOHtg6pwVSJZxHkloAVPyGlJ9 TDY+Nio3Zx2jVCGg9HlbZNkKRnKEvg75MgTAnUBs= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3914E6EC60 for ; Thu, 1 Apr 2021 12:38:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3914E6EC60 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1lRtmr-0002rI-D1; Thu, 01 Apr 2021 12:38:49 +0300 Date: Thu, 1 Apr 2021 12:37:55 +0300 To: Igor Munkin Message-ID: References: <4a8669339a59964c0b187263f864692946d51303.1616743343.git.skaplun@tarantool.org> <20210331225847.GW29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331225847.GW29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F53808504037E77D941107284F41D517EAB04B008D6687DCEE9CCF70E52A3C9B3616BBE7F6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D636C6B786B38B6A8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFE13C222FD2B1CDA12F9FE7D22070E7AEA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E97D2AE7161E217F117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5E2CD3FD592A2E50E074CB42EAA98DA8EE14E453284512BECD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340297C696F996E3845546AC12D6E7A23F13CE429F7579F96392B4528E5F3E491371207095B97F325A1D7E09C32AA3244C26E93E324863B123D54894E8F21CB23733C9DC155518937FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20J92ckTJewZKg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4C2AD5E9096C45EA4CECABE2364DDCC081E56CD8B432745C2F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 05/30] test: adapt arg availability test from Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 01.04.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider the comments below. > > On 26.03.21, Sergey Kaplun wrote: > > The argument table `arg` can be read (and modified) by `LUA_INIT` and > > `-e` chunks since the commit 92d9ff211ae864777a8580b5a7326d5f408161ce > > (Set arg table before evaluating LUA_INIT and -e chunks.). > > > > This behaviour is similar to Lua 5.3, so the test was adapted > > considering PUC-Rio Lua 5.3 test suite taken from > > https://www.lua.org/tests/lua-5.3.0-tests.tar.gz. > > > > Closes tarantool/tarantool#5686 > > As we discussed before: s/Closes/Resolves/. I used here Closes intentionly: I suppose, that the issue is not appeared in Tarantool's repo, so it is closed as far as the final version of patchset does not contain the issue. Looks that it is confusing, changed back to Resolves. Here and in the patches later. > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/main.lua | 14 ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > > index 4f8b8bf..c11a576 100644 > > --- a/test/PUC-Lua-5.1-tests/main.lua > > +++ b/test/PUC-Lua-5.1-tests/main.lua > > @@ -69,9 +69,19 @@ a = string.format(a, progname) > > prepfile(a) > > RUN('lua "-e " -- %s a b c', prog) > > > > -prepfile"assert(arg==nil)" > > +-- test 'arg' availability in libraries > > +-- LuaJIT: LuaJIT v2.1.0-beta3 has extension from Lua 5.3: > > +-- The argument table `arg` can be read (and modified) > > +-- by `LUA_INIT` and `-e` chunks. > > +-- See commit 92d9ff211ae864777a8580b5a7326d5f408161ce > > +-- (Set arg table before evaluating LUA_INIT and -e chunks.). > > +-- See also https://github.com/tarantool/tarantool/issues/5686. > > +-- In Lua 5.3 this feature was introduced via commit > > +-- 23f0ff95177eda2e0a80e3a48562cc6837705735. > > +-- Test is adapted from PUC-Rio Lua 5.3 test suite. > > +prepfile"assert(arg)" > > prepfile("assert(arg)", otherprog) > > -RUN("lua -l%s - < %s", prog, otherprog) > > +RUN('env LUA_PATH="?;;" lua -l%s - < %s', prog, otherprog) > > Why LUA_PATH is tweaked here? Looks like Roberto avoids to load some files with the same name that can be loaded by the old `LUA_PATH`. I preferred to take it intact from the Lua 5.3 test suite (even comment about `arg` availability). > > > > > prepfile"" > > RUN("lua - < %s > %s", prog, out) > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun