From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ACE6B6EC60; Thu, 1 Apr 2021 11:51:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ACE6B6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617267084; bh=zrU/HFD1ev380RLZ/w7FKQNNGssaOanQX2DSPmRZ7KE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yq6QTdcjXyhBzfyLMFm/rSfah1yQzwMZP/s6eKG0eY5WhY9F9XOmM0G/nDyyxWmMp vohCl+lp1NI/v4ZtKNG9pfliILssj+465gHMgpu8Wc47nBl/cnV5GDdAOFpHTRp5Nd H5Xejhg4IVyQxE8UCQqqDNzNNsJcAQa+dxYArO/k= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 707C86EC60 for ; Thu, 1 Apr 2021 11:51:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 707C86EC60 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1lRt2w-0002AU-IC; Thu, 01 Apr 2021 11:51:22 +0300 Date: Thu, 1 Apr 2021 11:50:25 +0300 To: Igor Munkin Message-ID: References: <5c12f508e83fb3a7191de7d24799ca3e072bf4c2.1616743343.git.skaplun@tarantool.org> <20210331225839.GV29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331225839.GV29703@tarantool.org> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709C5527BBE40F25C64182A05F53808504096714A0BEEDAC6EDCDEC59A00EC71B8FC79EB89072DFE58ADB7A12A6805A65E5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF3C614D30AB87508805D7D983A31C73CCA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4931B544F03EFBC4D57F409322A2F59C95CC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783183B40096F016153C8955918E15BC64BA X-C1DE0DAB: 0D63561A33F958A5929EC0B7996AD20815B91637B03FC58A458E0A2A45AB7719D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344EF254DC71474AA371B302062BF73866182C1BD5AC0B8266D3D2248912C84770A2DB5794D74294B51D7E09C32AA3244C8B12828931219C0F86D7B0A75823251295A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20KLcHPHKVMOYg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB44A03612F207D81D4249713DF2BB381F32EFB46E87CE71F93F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 04/30] test: remove quotes in progname from X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 01.04.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > When LUAJIT_TEST_COMMAND extend the least `arg` with > > Typo: s/LUAJIT_TEST_COMMAND extend/LUAJIT_TEST_COMMAND extends/. > Typo: s/the least `arg`/the least `arg` slot/. Fixed. > > > some string containing double quotes, bash failed to exec this > > Minor: I believe you're not talking about bash here, but rather > about and hence system(3) command, IIRC. Fixed. Thanks! > > > command for child test. > > > > This patch removes edged '"' to be able run extended command > > Minor: I guess "framing" fits better than "edging". > Typo: s/to be able run extended/to be able to run an extended/. Fixed. > > > containing '"' and run other test suites. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/main.lua | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > > index f520896..4f8b8bf 100644 > > --- a/test/PUC-Lua-5.1-tests/main.lua > > +++ b/test/PUC-Lua-5.1-tests/main.lua > > @@ -11,7 +11,9 @@ out = os.tmpname() > > do > > local i = 0 > > while arg[i] do i=i-1 end > > - progname = '"'..arg[i+1]..'"' > > + -- LuaJIT: remove edged '"' to be able run extended command > > Minor: I guess "framing" fits better than "edging". > Typo: s/to be able run extended/to be able to run an extended/. Fixed. > > > + -- containing '"' and run other test suites. > > + progname = arg[i+1] > > end > > print(progname) > > > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun