From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E3E316EC60; Thu, 1 Apr 2021 11:44:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E3E316EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617266644; bh=+T8SAFxmG6FjGEryl0pCq3AY06pKDpdGiptOWgBhQ8M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=n2EzXIKsF3eubD7F0noxapTSdbzNknyaFL7uKPN2d6r7QOl6iZJbPYiCCVJs6ODIW Ilc0TIXq0oW+dI7s1m96TnLGUQBUv0Db1iLZkwXCLl1Pdd2D6I4hDvVkiIUVuSCjE4 LvPdp0JzfLnG9EOCdXFkffdyYRDaJItMTFuFqnXY= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB1956EC60 for ; Thu, 1 Apr 2021 11:44:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB1956EC60 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1lRsvr-00076F-4C; Thu, 01 Apr 2021 11:44:03 +0300 Date: Thu, 1 Apr 2021 11:43:08 +0300 To: Igor Munkin Message-ID: References: <20210331225829.GU29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210331225829.GU29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F538085040EB8F6426DF2937F6E3B5D55C282A0D5CC79EB89072DFE58A418AD185D2AAA3C5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F9CBC1404CDFA5A08638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFDC1569DBEACD0A2182F1D1E5E63D5E95A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F790063735872C767BF85DA227C277FBC8AE2E8BA6406A2B830B443475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5C32EE799A2CC002304A750B87F41F97F00B4E8C65D7E1E1ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34411AA3F52B5778B68F857B7D9CDAD9F12FD26D187DCA26EC72B13639FE680BA476CA2D4079DBBE601D7E09C32AA3244CFC8CC3112714D641B1E33485A2FC491F95A9E0DC41E9A4CFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20KrR+H6gjieRQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4670428D055F5F024E26DCF6BFDDC73DAEF7A0A61D8A7E583F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 03/30] test: adapt Lua 5.1 suite for out-of-source build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 01.04.21, Igor Munkin wrote: > Sergey, > > On 26.03.21, Sergey Kaplun wrote: > > Hi! > > > > Thanks for the review! > > > > On 26.03.21, Sergey Ostanevich wrote: > > > LGTM, just minor changes to commit message. > > > > > > Sergos > > > > > > > > > > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: > > > > > > > > When tests are run out-of-source redefined `dofile()` function > > > ^ I had problem reading here the > > > ‘out-of-source redefined’. Can you put the ‘when..’ to the appropriate > > > place at the end of the sentence? ’The redefined … when … ‘ > > > > Fixed. > > > > The new committ message is the following (branch is force-pushed): > > But what is fixed in the new version? I see the sentence Sergos asked to > reword is left intact. Brr, sorry. Looks like I changed it twice. Thanks for the catch! The new version (checked twice): =================================================================== test: adapt Lua 5.1 suite for out-of-source build The redefined `dofile()` function failed to find the test file to load, when tests are run out-of-source. So, fullpath is detected considering `arg[0]` value. Moreover, some tests use `loadfile()` instead, so their argument is adjusted to the full path to the files. However, test in creates a temporary file and executes it via `dofile()` too, so this case is handled by the second argument -- `prefix` equals an empty string for current working directory. Part of tarantool/tarantool#5845 Part of tarantool/tarantool#4473 =================================================================== > > > > > =================================================================== > > test: adapt Lua 5.1 suite for out-of-source build > > > > When tests are run out-of-source redefined `dofile()` function failed to > > find the test file to load. So, fullpath is detected considering > > `arg[0]` value. Moreover, some tests use `loadfile()` instead, so their > > argument is adjusted to the full path to the files. > > > > However, test in creates a temporary file > > and executes it via `dofile()` too, so this case is handled by > > the second argument -- `prefix` equals an empty string for > > current working directory. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > =================================================================== > > > > > > > > > failed to find file to load. So, fullpath is detected considering > > > > `arg[0]` value. Moreover, some tests use `loadfile()` instead, so > > > > their argument is adjusted to the full path to the files. > > > > > > > > However, test in creates a temporary file > > > > and executes it via `dofile()` too, so this case is handled by > > > > the second argument -- `prefix` equals an empty string for > > > > current working directory. > > > > > > > > Part of tarantool/tarantool#5845 > > > > Part of tarantool/tarantool#4473 > > > > > > > -- > > > > 2.31.0 > > > > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun