From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 65C2A6EC60; Thu, 1 Apr 2021 11:41:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 65C2A6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617266506; bh=+roQbKJpZZmnV4JL6/jxzc8MOps+grNB8dSljwTxLXk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LJJJr+4OY3twzeMBbMSS94yCheM0PObVj9OYFjG8QfP8n5Kd5UT8+/+9DDyqINJtJ pjs76ONXLZQ0O5D0P8+PsWPUyaYO3tAa3/giawH3Un9IIuLXzgGwmxCfwDe0Thsqtm XLOPPTRDIiIh9lZH7A5pIfTsv3gFQmE7VnR2FjQA= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30DBC6EC60 for ; Thu, 1 Apr 2021 11:41:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30DBC6EC60 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lRstc-00016u-F6; Thu, 01 Apr 2021 11:41:44 +0300 Date: Thu, 1 Apr 2021 11:40:43 +0300 To: Igor Munkin Message-ID: References: <20210331225823.GT29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331225823.GT29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040AEAC62B38690794B4FE8730DB946A99E4A70F43332CFAB88B0CF764773666B99 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E628FE8A185FCFBEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063775FF68B4B43662428638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFCBD5365C0DD6258EEA4DAF2C62B45185A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4931B544F03EFBC4D57F409322A2F59C95CC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5880B18210E615832468A6E4E7032EF6A35FBC33FF535176DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348B532EA2091F4FF6063FB205CF7FAA1FFC2976E4C0D9C18BE8212641EB4D6006CFAC52B85BAA47341D7E09C32AA3244C335C7D04633163D4434632E91176959ACE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20JYqTmoRVs7eQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB49D7D07090D9C32266317F6652E73C85B9813931AED30AC19F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 03/30] test: adapt Lua 5.1 suite for out-of-source build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 01.04.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Honestly, I'm not fond of the solution you > implemented, though it allows to make as little changes as possible. > I propose to implement something similar to the solution you've made > within lua-Harness series: > * You need two functions: one for launching source files for > additional checks and another one for running temporary Lua chunks. > * You also need two functions for the same reason. > > Mind the fact is implemented via , so basically, > there might be no so much changes made for . Thoughts? I prefer to use one function, and two wrappers around it. For example, let it be `absolute_dofile()` and `cwd_dofile()`. But honestly, it is not the single one problem of this suite (no test isolation, global variables, huge excess output, hardcoded limit values, etc). It looks like we need to refactor this suite later (plus adapt test for LuaJIT extensions from Lua 5.2+). I propose to do all this work via that refactoring, not now. Otherwise, it looks like a patch, which will still need to be refactored later. Thoughts? > > -- > Best regards, > IM -- Best regards, Sergey Kaplun