From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FD016EC60; Thu, 1 Apr 2021 15:04:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FD016EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617278692; bh=73bvI5eOjaoMn5bg8j3xeTDLIG4L4yEKL/ea3BzqM0Q=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rI8KyWjcguXJxc9C1LGTDYmlCy5dWAYEVK7jx0aEswNZyxNy16ZsAj6W5pBiC7xr6 xI/12/ZFwLeDSyYu0MolQwEkCQ+0m/1AfE3BxCK8o/KrhmF5iA3nqcBnBV8NLat1mA si7ZtOR0WvXRwRck6gNojgaFwOnTMQnmWhDmsNxs= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 818A56EC60 for ; Thu, 1 Apr 2021 15:04:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 818A56EC60 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1lRw49-0002rN-I3; Thu, 01 Apr 2021 15:04:50 +0300 Date: Thu, 1 Apr 2021 15:03:55 +0300 To: Igor Munkin Message-ID: References: <20210330221615.GZ29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221615.GZ29703@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F5380850406DF69A1C731FC25A45D703A98212573E7960D425B2DC08E4E1530E0810D6777F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745D431239A8C7DA08638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF4D667BB374251E40B4644BB2952D41CBA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FD59DAE6580CC3C3117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006376F83E65DF5A39473EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A557EC1F4E82FF1FB617C0F016B93045B164BA7C3C7A1E38C2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3430FC2BC1B917F018F2023E1FAFDA28F7924CA77603D505DAABAE4530E37345A7A8501B5F629CB6A91D7E09C32AA3244CCBFB39A9CD507AD7EA89207C56F592646C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20I2J4wnMIotdQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4E58C873BCFF8F3A054E13887DEF54640928D2CF378FF6A24F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/30] test: disable PUC-Lua test for per-coroutine hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the one nit: I would explicitly > mention that hook is set *but* for the whole VM instead of the given > coroutine. Hence hooks work, but assertions are disabled. Added to the commit message and the comment in the code. > > -- > Best regards, > IM -- Best regards, Sergey Kaplun