From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B63796EC60; Thu, 1 Apr 2021 14:59:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B63796EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617278395; bh=0lfkWzRcauxAKc+8Zkp4XiWS2ByZvJqo65G6SZ8p9Aw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tcyWjny3fHOZluvjHP44ebh7CeIXdxPSU+4EtMs5RZQiHlmAky1SjgYWLBX1Ny3r7 Qho1KVaHkj01kaI0n8zefwnrH8+NPbteBua63qPDby6FS9UqKtvDorRQKqygvnXvxs PD1jRs0M/3JRUXLKkzlLiyF+6zNKu8Q1B8Xwzkco= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E32976EC60 for ; Thu, 1 Apr 2021 14:59:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E32976EC60 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1lRvzN-00054K-3g; Thu, 01 Apr 2021 14:59:53 +0300 Date: Thu, 1 Apr 2021 14:58:58 +0300 To: Igor Munkin Message-ID: References: <679ac3ff8cbcf449c2e47cc9d4446c3dcf0300d1.1616743343.git.skaplun@tarantool.org> <20210330221558.GY29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221558.GY29703@tarantool.org> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709C5527BBE40F25C64182A05F5380850400786EE9EC188AC887A73808AEF2CDDB5AED6D2A222EDE8D537DB2B2EAE20E450 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77633BACAB33B9508C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7AC4684DF4EC4B256EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664A83F087A86AB34AC684D753841DF371E7A11F26B6827AD7F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE72F88032165008D51731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A53F043EA408FB84A88D5CB4CAEEADEBCAB895FF9F9687EAFFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9873270276D43345C2F312F958F0FDB4B9C3BB292C1C0296869A5CCC66684CC0B86BBB52BFF0EC01D7E09C32AA3244C6959E79E3D82D98E0F2B4C7D0F0E63C97C0C08F7987826B9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20LQSVOyMbrqAg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB464BB65FD3202051106EB73CC469794CCC38A58EB0CD9891DF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 14/30] test: adapt activeline check in the PUC Lua test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT does not report line with single "end" statement > > Typo: s/report line/report the line/. Fixed. > > > (the last line of the function) as an active line in > > debug.getinfo(), unlike Lua does. There is no bytecode > > related to this line, so it is "unreachable" and > > may be considered not active. > > > > This patch excludes the last line of a function from the check, > > Typo: s/a function/the function/. Fixed. > > > considering LuaJIT's behaviour. > > > > Closes tarantool/tarantool#5708 > > As we discussed before: s/Closes/Resolves/. Fixed. > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/db.lua | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > > index b363abc..c704877 100644 > > --- a/test/PUC-Lua-5.1-tests/db.lua > > +++ b/test/PUC-Lua-5.1-tests/db.lua > > @@ -491,7 +491,15 @@ local _, l = coroutine.resume(co, 10) > > local x = debug.getinfo(co, 1, "lfLS") > > assert(x.currentline == l.currentline and x.activelines[x.currentline]) > > assert(type(x.func) == "function") > > -for i=x.linedefined + 1, x.lastlinedefined do > > +-- LuaJIT does not report line with single "end" statement > > Typo: s/report line/report the line/. Fixed. > > > +-- (the last line of the function) as an active line in > > +-- debug.getinfo(), unlike Lua does. There is no bytecode > > +-- related to this line, so it is "unreachable" and > > +-- may be considered not active. > > +-- See also https://github.com/tarantool/tarantool/issues/5708. > > +-- LuaJIT: Test is adapted for LuaJIT's behaviour by avoiding > > +-- the last line check. > > +for i=x.linedefined + 1, x.lastlinedefined - 1 do > > assert(x.activelines[i]) > > x.activelines[i] = nil > > end > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun