From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D786B6EC60; Thu, 1 Apr 2021 14:53:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D786B6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617278033; bh=iSOCmneefdB2h1ZBlpgPqznRZN7pEXfrHHHiKLViMBE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=K5mBehSJH5cKUj2xb1/Lgon087faO49U9IYX5SgILGTABrohwcENwYfqaKG3zjOWC SDNYUUr4aWV5fyn1rBWitZXFJ7CiMQpPG4AcE+xE7R8nB81TKmIuvmZMWE3HtNzvmh s0fIPDut7c2Kf97hSryX2nblAhjtpEOhqIjVX6Oo= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E78276EC60 for ; Thu, 1 Apr 2021 14:53:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E78276EC60 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1lRvtX-0002Po-5M; Thu, 01 Apr 2021 14:53:51 +0300 Date: Thu, 1 Apr 2021 14:52:57 +0300 To: Igor Munkin Message-ID: References: <43c7a2668c9d3935e792363a7a6536a4801e28a8.1616743343.git.skaplun@tarantool.org> <20210330221534.GX29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221534.GX29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040FB9DA1094FB42FFFB958F5215C13662AA718930A168CF9997386B9E1210E2077 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7495A032B936E882FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372A1456D053D20C618638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF01239603016926B68D8405ADD6EB267FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006376F83E65DF5A39473EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5112CD6FFF0F2DC9D0BC4C91C3497F3F639C05B8A3EE03253D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53592357E8057733346EE4A729063C826523068A18EA294FFFECC1AA44FDC5CAEA6015C89BDF3EA1D7E09C32AA3244C153650BBC889ECF3E677D9787687ABBE853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20IPxOKAMiOxiA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB417D2698BCF9027346A64BA219B054138C105183BBDB93524F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 13/30] test: disable PUC Lua test for tail call info X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the patch! LGTM, except the nits below. > > On 26.03.21, Sergey Kaplun wrote: > > LuaJIT does not provide information about tail calls in debug.getinfo(), > > unlike Lua does. This missed feature is described in > > https://luajit.org/status.html. > > > > This patch disables tests for tail call checks and getfenv() checks, > > because tail calls do not provide an additional level for LuaJIT > > It's not "level", but "call frame", AFAIU. Fixed. > > > and level number given to getfenv() should be changed. > > > > Relates to tarantool/tarantool#5702 > > Relates to tarantool/tarantool#5703 > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/db.lua | 30 ++++++++++++++++++++++-------- > > 1 file changed, 22 insertions(+), 8 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > > index c1a635a..b363abc 100644 > > --- a/test/PUC-Lua-5.1-tests/db.lua > > +++ b/test/PUC-Lua-5.1-tests/db.lua > > @@ -400,19 +400,29 @@ function g1(x) g(x) end > > > > local function h (x) local f=g1; return f(x) end > > > > -h(true) > > +-- LuaJIT does not provide information about tail calls, > > +-- unlike Lua does. See also https://luajit.org/status.html. > > +-- getfenv() behaviour is also different here, > > Typo: looks like line underfull (in LaTeX terms, heh). Fixed. > > > +-- because tail calls do not provide additional level for LuaJIT > > +-- and level number should be changed. > > +-- FIXME: Test is disabled for LuaJIT. > > +-- See also https://github.com/tarantool/tarantool/issues/5702. > > +-- h(true) > > > > > -for _, k in ipairs(res) do assert(k == table.remove(b, 1)) end > > - > > Typo: excess whitespace change. Fixed. > > > +-- Behavior is different for LuaJIT. See the comment above. > > +-- FIXME: Test is disabled for LuaJIT. > > +-- for _, k in ipairs(res) do assert(k == table.remove(b, 1)) end > > > > > -- > > 2.31.0 > > > > -- > Best regards, > IM -- Best regards, Sergey Kaplun