From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9148C6EC60; Wed, 31 Mar 2021 12:42:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9148C6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617183739; bh=n0gXA8TMsXISH7gnTmqmglVMDuVwhVoIcPv9pi2B0vU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kXKmQl6sK77Xl5jtwnkqGX/mk7E9gCQr3wgzT5dAj8guon0Oxb0FeL0BnQAA3RhqF ypPdUj0UAETaZJHbpoJlZBiakdpcr+ekbHffCZLLpeqju3l9FWWoah5WZCsAj9shUZ qANwhVj8SaydyxiyG2dVB40/m7dxKxvVJDz1ozJE= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D41E6EC60 for ; Wed, 31 Mar 2021 12:42:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D41E6EC60 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1lRXMf-0006x3-9Y; Wed, 31 Mar 2021 12:42:17 +0300 Date: Wed, 31 Mar 2021 12:41:23 +0300 To: Igor Munkin Message-ID: References: <20210330221740.GF29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330221740.GF29703@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040FF19F4A5B8F3CCFFC12D0EAB64538CA29D3126A72A696AA38AAF19D0CF45B3B5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B28E90C11C329EF18638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF5FD586CFF284ADA15DDDD79D249A4F0FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3BD39A56654533F91117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5FB3C22F57DCA967A1144F1A19BC578F479A905299A29B40DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343DCFC3BEDFB0242D2F3F8A031C4BE0D06A0E9FC5659AD4A8CF26929D1DE4574F773B1894BE9E2D961D7E09C32AA3244CF10DAFA01CF5A26D302C9B57E0D72CD29CA7333006C390A0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoaIT3B2d5no4A== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4ED405A92DCE9A380720B90FA3D731CA467DF199C8C3DFBD9F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 00/30] Adapt PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 31.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the series! I have two global comments for it: > * 'LuaJIT:' tag usage looks inconsistent: let's move all of them to the > beginning of the related comments. OK, I'll fix it with the new one series version, if you don't mind. > * Typo: s/LuaJIT's/LuaJIT/g. > E.g. you never say "room's door" or "street's name". If you find the > rule of possessives adjectives usage with inanimate subjects, please, > share it with me. According to "The Oxford Dictionary of American Usage and Style" by Bryan A. Garner, **POSSESIVES**, **H Inanimate things** section, page 262: | **Inanimate Things**. Possessives of nouns denoting inanimate objects | are generally unobjectionable. Indeed, they allow writers to avoid | awkward uses of `of` -- e.g.: `the book's title`, `the article's main | point`, `the system's hub`, `the envelope's contents`, `the car's | price tag`. | | The old line was that it's better to use an "`of` phrase rather than | the `'s` to indicate possession when the possessor is an inanimate | object. Write `foot of the bed`, not `the bed's foot`" (Robert C. | Whitford & James R. Foster, Concise Dictionary of American and Usage, | 1955). `Foot of the bed`, of course, is a SET PHRASE, the example is | not a fair one. As a general principle, though, whenever it's not a | violation of idiom, the possessive in `'s` is preferable - . | | But such possessives can be overdone for example, avoid using the | possessive form of a year -- e.g.: "Mr. Rogers, 41, took the show by | storm in 1993 winning 28 blue ribbons and the Show Sweepstakes with a | total of 1,120 points (which really upped the ante: `1992's winner` | [read `the 1992 winner`] scored only 387 points" (N. Y. Times). > * You use "PUC-Lua", "PUC Lua" and just "PUC" or "Lua" in commit > subjects. Let's choose the single way referencing this Lua language > implementation (and the corresponding test suite). Let's use "PUC" phrase everywhere, if you don't mind -- "test:" prefix of commit message defines belonging to the test suite. > > -- > Best regards, > IM -- Best regards, Sergey Kaplun