From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 87EDC6EC5B; Tue, 30 Mar 2021 14:55:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87EDC6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617105341; bh=cxOxiSaT6MsQAnWJZxN3I1L2vxFT5u5lVonqPk+xiGg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=b+8ZfdbMeAWLpYp5HHRhppGsNEa1wIQVUz+c0MM6WSovFrVq1Ho/23kp8UTFYrqXE AqU57ykBOFUnvnJHqDebx0Qp7r2XImYSpY0DYBHE4vE6yYM4nNY530oZ1Kku9S0iNd vQ2vXhCGg54agxuX6BchqvLCTUF+ZspcWJsLj/5M= Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C936C6EC5B for ; Tue, 30 Mar 2021 14:55:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C936C6EC5B Received: by mail-lj1-f178.google.com with SMTP id u9so19521300ljd.11 for ; Tue, 30 Mar 2021 04:55:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dJ0miiO/7HR0kEITNRQWcGlUcr2kmjhAKCehOt/EHK8=; b=RjoPwbE0E+Np9LkBzS/TgrEpWWXJOVgenXcXyxqRbFm8R2P1dc9JTpZcVA6E9Z99Dt dAJ63oVDHvIvppihmSe7mjb/QRFmSB7EjWEHVwjCxT7LAI+0GEhAXs0mZcc3jWs3+78Q 6GR0smPBe2bEZr+pOCnEllmheMpMHRuLc5tIGy4epK+LAFsiT50z5jcur8j+NKeWmkCd 37M9pjCzmLoO4oLToPYOQ7szRJbC/Ej1Xn2D+KnxyEy5EFNhZAcvGaod1m4WQVhb9dyH 2Y/fJA+syQXN/AxXyEhV+eSIovHvBJuxajFq7zIrR44Cm9Xxu7Tu5i3ug+b86rcfA6wC 74qw== X-Gm-Message-State: AOAM531x7fImPItarlJL0UYftkWrlw7OhFsAeqTV6NiENr2lLnWWmnJ1 uFLdsr1pntbAru4+MsZutB/kbe0NBNF2aQ== X-Google-Smtp-Source: ABdhPJxwU7AfMliGjW8OXZaPLCLNtKkYqKGgjTP8/DaM+9xRngUnRCcEuMQV8HivpxXYOh6GZd8Mzg== X-Received: by 2002:a2e:b817:: with SMTP id u23mr20279829ljo.44.1617105338418; Tue, 30 Mar 2021 04:55:38 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id f8sm2766420ljn.1.2021.03.30.04.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Mar 2021 04:55:36 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 61CEC5601D4; Tue, 30 Mar 2021 14:55:36 +0300 (MSK) Date: Tue, 30 Mar 2021 14:55:36 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> <5195a08c-aaa7-7aa4-8324-352a9433955f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Mar 30, 2021 at 10:19:56AM +0300, Cyrill Gorcunov wrote: > > Vlad, lets move another way. I suspect there are 3 ways to compare > > 1) assert(is_paused == false) > 2) assert(not is_paused) > 3) is_running = not is_paused > assert(is_running) > > so which of them I should use? Here is a final update on top I've pushed out. Hopefully it is the one you prefer to see. I put a complete result file for better review. --- -- test-run result file version 2 -- -- gh-5806: defer xlog cleanup to keep xlogs until -- replicas present in "_cluster" are connected. -- Otherwise we are getting XlogGapError since -- master might go far forward from replica and -- replica won't be able to connect without full -- rebootstrap. -- fiber = require('fiber') | --- | ... test_run = require('test_run').new() | --- | ... engine = test_run:get_cfg('engine') | --- | ... -- -- Case 1. -- -- First lets make sure we're getting XlogGapError in -- case if wal_cleanup_delay is not used. -- test_run:cmd('create server master with script="replication/gh-5806-master.lua"') | --- | - true | ... test_run:cmd('start server master') | --- | - true | ... test_run:switch('master') | --- | - true | ... box.schema.user.grant('guest', 'replication') | --- | ... -- -- Keep small number of snaps to force cleanup -- procedure be more intensive. box.cfg{checkpoint_count = 1} | --- | ... engine = test_run:get_cfg('engine') | --- | ... s = box.schema.space.create('test', {engine = engine}) | --- | ... _ = s:create_index('pk') | --- | ... test_run:switch('default') | --- | - true | ... test_run:cmd('create server replica with rpl_master=master,\ script="replication/replica.lua"') | --- | - true | ... test_run:cmd('start server replica') | --- | - true | ... -- -- On replica we create an own space which allows us to -- use more complex scenario and disables replica from -- automatic rejoin (since replica can't do auto-rejoin if -- there gonna be an own data loss). This allows us to -- trigger XlogGapError in the log. test_run:switch('replica') | --- | - true | ... box.cfg{checkpoint_count = 1} | --- | ... s = box.schema.space.create('testreplica') | --- | ... _ = s:create_index('pk') | --- | ... box.space.testreplica:insert({1}) | --- | - [1] | ... box.snapshot() | --- | - ok | ... -- -- Stop the replica node and generate -- xlogs on the master. test_run:switch('master') | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... box.space.test:insert({1}) | --- | - [1] | ... box.snapshot() | --- | - ok | ... -- -- We need to restart the master node since otherwise -- the replica will be preventing us from removing old -- xlog because it will be tracked by gc consumer which -- kept in memory while master node is running. -- -- Once restarted we write a new record into master's -- space and run snapshot which removes old xlog required -- by replica to subscribe leading to XlogGapError which -- we need to test. test_run:cmd('restart server master') | box.space.test:insert({2}) | --- | - [2] | ... box.snapshot() | --- | - ok | ... assert(not box.info.gc().is_paused) | --- | - true | ... -- -- Start replica and wait for error. test_run:cmd('start server replica with wait=False, wait_load=False') | --- | - true | ... -- -- Wait error to appear, 60 seconds should be more than enough, -- usually it happens in a couple of seconds. test_run:switch('default') | --- | - true | ... test_run:wait_log('master', 'XlogGapError', nil, 60) ~= nil | --- | - true | ... -- -- Cleanup. test_run:cmd('stop server master') | --- | - true | ... test_run:cmd('cleanup server master') | --- | - true | ... test_run:cmd('delete server master') | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... test_run:cmd('cleanup server replica') | --- | - true | ... test_run:cmd('delete server replica') | --- | - true | ... -- -- Case 2. -- -- Lets make sure we're not getting XlogGapError in -- case if wal_cleanup_delay is used the code is almost -- the same as for Case 1 except we don't disable cleanup -- fiber but delay it up to a hour until replica is up -- and running. -- test_run:cmd('create server master with script="replication/gh-5806-master.lua"') | --- | - true | ... test_run:cmd('start server master with args="3600"') | --- | - true | ... test_run:switch('master') | --- | - true | ... box.schema.user.grant('guest', 'replication') | --- | ... box.cfg{checkpoint_count = 1} | --- | ... engine = test_run:get_cfg('engine') | --- | ... s = box.schema.space.create('test', {engine = engine}) | --- | ... _ = s:create_index('pk') | --- | ... test_run:switch('default') | --- | - true | ... test_run:cmd('create server replica with rpl_master=master,\ script="replication/replica.lua"') | --- | - true | ... test_run:cmd('start server replica') | --- | - true | ... test_run:switch('replica') | --- | - true | ... box.cfg{checkpoint_count = 1} | --- | ... s = box.schema.space.create('testreplica') | --- | ... _ = s:create_index('pk') | --- | ... box.space.testreplica:insert({1}) | --- | - [1] | ... box.snapshot() | --- | - ok | ... test_run:switch('master') | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... box.space.test:insert({1}) | --- | - [1] | ... box.snapshot() | --- | - ok | ... test_run:cmd('restart server master with args="3600"') | box.space.test:insert({2}) | --- | - [2] | ... box.snapshot() | --- | - ok | ... assert(box.info.gc().is_paused) | --- | - true | ... test_run:cmd('start server replica') | --- | - true | ... -- -- Make sure no error happened. test_run:switch('default') | --- | - true | ... assert(test_run:grep_log("master", "XlogGapError") == nil) | --- | - true | ... test_run:cmd('stop server master') | --- | - true | ... test_run:cmd('cleanup server master') | --- | - true | ... test_run:cmd('delete server master') | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... test_run:cmd('cleanup server replica') | --- | - true | ... test_run:cmd('delete server replica') | --- | - true | ... -- -- -- Case 3: Fill _cluster with replica but then delete -- the replica so that master's cleanup leave in "paused" -- state, and then simply decrease the timeout to make -- cleanup fiber work again. -- test_run:cmd('create server master with script="replication/gh-5806-master.lua"') | --- | - true | ... test_run:cmd('start server master with args="3600"') | --- | - true | ... test_run:switch('master') | --- | - true | ... box.schema.user.grant('guest', 'replication') | --- | ... test_run:switch('default') | --- | - true | ... test_run:cmd('create server replica with rpl_master=master,\ script="replication/replica.lua"') | --- | - true | ... test_run:cmd('start server replica') | --- | - true | ... test_run:switch('master') | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... test_run:cmd('cleanup server replica') | --- | - true | ... test_run:cmd('delete server replica') | --- | - true | ... test_run:cmd('restart server master with args="3600"') | assert(box.info.gc().is_paused) | --- | - true | ... test_run:switch('master') | --- | - true | ... box.cfg{wal_cleanup_delay = 0.01} | --- | ... test_run:wait_cond(function() return not box.info.gc().is_paused end) | --- | - true | ... test_run:switch('default') | --- | - true | ... test_run:cmd('stop server master') | --- | - true | ... test_run:cmd('cleanup server master') | --- | - true | ... test_run:cmd('delete server master') | --- | - true | ... -- -- Case 4: Fill _cluster with replica but then delete -- the replica so that master's cleanup leave in "paused" -- state, and finally cleanup the _cluster to kick cleanup. -- test_run:cmd('create server master with script="replication/gh-5806-master.lua"') | --- | - true | ... test_run:cmd('start server master') | --- | - true | ... test_run:switch('master') | --- | - true | ... box.schema.user.grant('guest', 'replication') | --- | ... test_run:switch('default') | --- | - true | ... test_run:cmd('create server replica with rpl_master=master,\ script="replication/replica.lua"') | --- | - true | ... test_run:cmd('start server replica') | --- | - true | ... test_run:switch('default') | --- | - true | ... master_uuid = test_run:eval('master', 'return box.info.uuid')[1] | --- | ... replica_uuid = test_run:eval('replica', 'return box.info.uuid')[1] | --- | ... master_cluster = test_run:eval('master', 'return box.space._cluster:select()')[1] | --- | ... assert(master_cluster[1][2] == master_uuid) | --- | - true | ... assert(master_cluster[2][2] == replica_uuid) | --- | - true | ... test_run:cmd('stop server replica') | --- | - true | ... test_run:cmd('cleanup server replica') | --- | - true | ... test_run:cmd('delete server replica') | --- | - true | ... test_run:switch('master') | --- | - true | ... test_run:cmd('restart server master with args="3600"') | assert(box.info.gc().is_paused) | --- | - true | ... -- -- Drop the replica from _cluster and make sure -- cleanup fiber is not paused anymore. test_run:switch('default') | --- | - true | ... deleted_uuid = test_run:eval('master', 'return box.space._cluster:delete(2)')[1][2] | --- | ... assert(replica_uuid == deleted_uuid) | --- | - true | ... test_run:switch('master') | --- | - true | ... test_run:wait_cond(function() return not box.info.gc().is_paused end) | --- | - true | ... test_run:switch('default') | --- | - true | ... test_run:cmd('stop server master') | --- | - true | ... test_run:cmd('cleanup server master') | --- | - true | ... test_run:cmd('delete server master') | --- | - true | ...