From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 35F5C6EC5B; Tue, 30 Mar 2021 01:40:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 35F5C6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617057647; bh=Irdi9+pjUZrthe1dRlrDp5kw0qOcIswvf85AaME4Qn8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hqGClKuRhxuldgYDo7A3tQhDlbS8SOaPfDXTZccgpUqi+rcV3sWkbWgfVUZhh37p7 AY3Y17b492fMgGYCFI0fS58AZgputa+orTbzhpyG5zv1QvfSmWx9bEpeOfhYfNQh1b 4CP8qKwZsKfgqqG8XJbrKxVQMrXhqRd3D9byzdqg= Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4C73B6EC5B for ; Tue, 30 Mar 2021 01:40:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4C73B6EC5B Received: by mail-lj1-f180.google.com with SMTP id u20so17644184lja.13 for ; Mon, 29 Mar 2021 15:40:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P2hcAfMQP25nbYdbHhJN1ccdwEX+6TssUTXAQnCidj0=; b=Xo923FsJ5l3r5zHBvpIvksn3QJKvPINHmLOk6kTfhAM+rxY7QmYmVjwwbCnyLjCplf rYgSAmVulZnfl6d4ZoSgQDW+d+ukiGA+qzLRducGDKowzr2qIdYYtcaN1DEPEvh/GuWp g+5IkL+Fkr7U1X3kxU5JrxQLBKiv36WGtUM6yWJ5j6yKFBikwq4Eo4eIZaRBfxF2QHY0 6Q608ts8tW40lbN+CGepBlANBQ9/HuRwUomz2wVsq1iwLovD7inmegobUyru3SigMesw FvFPtlytEJOZtKDf59+qDETZV/XWWrV6zHjHiktvnA6C40bP3Sj8R5PaxbrmrKw0eSRc k72A== X-Gm-Message-State: AOAM5300QsdgLEaadU1CbTK0xgoP/5gFtEv//V0I9W1sllfEN4xEx+e/ vJN4AZSASG6bcRLnHRebv0MLpgUxPQMApg== X-Google-Smtp-Source: ABdhPJy1tuyM/KZSCiJI4+oD69zuwWOd78PRsXi4fPKX5XYTFSJ6psUrABKE1RuoytJaLRUoAUcFVQ== X-Received: by 2002:a2e:9cc4:: with SMTP id g4mr19342406ljj.34.1617057644203; Mon, 29 Mar 2021 15:40:44 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id u25sm1970564lfk.213.2021.03.29.15.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 15:40:43 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 46F575601D4; Tue, 30 Mar 2021 01:40:42 +0300 (MSK) Date: Tue, 30 Mar 2021 01:40:42 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Mar 30, 2021 at 12:19:10AM +0200, Vladislav Shpilevoy wrote: > > > > I need to make sure the .is_paused is false, the assert(x == false) > > looks exactly what is needed. and we have similar code in our other > > tests, do you prefer assert(not x.is_paused) or what? > > And there is much much much more tests using the booleans as they > are supposed to be used. Why do you need exactly 'false' as a literal? Wait, I just don't understand. is_paused is a boolean type and I compare it with a boolean value. Could you simply point me the preferred way to compare if some particular value is false. I used assert() 'cause I found similar code, if there some more suiatble way to test the value, sure thing I can use whatever you prefer, just point me an example.