From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 48B5D6EC5B; Tue, 30 Mar 2021 00:57:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 48B5D6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617055059; bh=VEdt/zIRUlHUbLTJsV0YnSwJEuL45uzzRQhasqVlnVQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OrLBj00kVtzm41BHJikb2rLo6+CNOEfsdlG0zn9TgeI3eHsDfUnBugMzkBJK4X4tl sdJqdlBEH3ZlBeM6Up91/fSbDE4Mw5XCLmqGsLppW6dRUndfIRtsUR77yDyThvpZfK 0nIj85lva4uVe5WWx0PjqOXiXs+A490MGQzBcLys= Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39D776EC5B for ; Tue, 30 Mar 2021 00:57:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 39D776EC5B Received: by mail-lj1-f178.google.com with SMTP id y1so17570637ljm.10 for ; Mon, 29 Mar 2021 14:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ysYUEijx0cLf51suZ4wdYsZO46cT7BODZG1cbxJsnd0=; b=ZiVUJSrk6S5fcbHN+5Ood3cv2hlbFMGavgPkw7XgdznMHNsQwNbvoUHW06eboiiosU WYV8cqzgzLV6xWRN5jtlCmmEkOt65dJjFRdC6Fq1j+Efu/eIiHJTm8T05EupdzbOSWoE K08INaaX0oSQqVTeb4g6FGQB7ZBlRIDD9RRv8nmmghUWysphH8dO27wilM0+WoKXj+bq l0sEBlOBmrhaNhy+/0tO2SWKEIfEWwOY2PdE26JnwCVV5T7hJdMmqngIfomCEJUhBJxK VLYAzrcvSsNXkjrDFhOgXCBpCJKN7ftxW8tTJtsfxKgTzZAlhJukaJZPvFLwXUgEQEvu M7xg== X-Gm-Message-State: AOAM532kc7e2EzU5ZEjVfGUdhr4cO4iAOF87A3yw5cW3eXpPJHjWe46x C7cwIO533emvbLJuSWnXw2I87BosevClbQ== X-Google-Smtp-Source: ABdhPJwqq1jgaXDfyben7wafIn08gCLbcjFPSMyQKq8xyfccDuke4hJIOWnHC/qBFEKq3NUZWSqdFA== X-Received: by 2002:a2e:6f15:: with SMTP id k21mr19544837ljc.444.1617055057172; Mon, 29 Mar 2021 14:57:37 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id a16sm2576835ljj.124.2021.03.29.14.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 14:57:36 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 57BDE5601D4; Tue, 30 Mar 2021 00:57:35 +0300 (MSK) Date: Tue, 30 Mar 2021 00:57:35 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Mar 29, 2021 at 11:54:45PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! > > Please, don't try to rush and answer my comments immediately after > I send them. Even if they seem trivial. It won't speed the things > up, and you will simply miss something, as I told many times. > > You still left 3 usages of 'is_paused == false', even though > I specifically said this is the most confusing one. I need to make sure the .is_paused is false, the assert(x == false) looks exactly what is needed. and we have similar code in our other tests, do you prefer assert(not x.is_paused) or what?