From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A119F6EC60; Mon, 29 Mar 2021 16:01:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A119F6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617022913; bh=vKL/5Gt8gnDJf3krpzoNJXkG485e9m8Tmp4RAMMrUAc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cDuOiB65E1dTtpyXgW4ls1OVwZjnS5xOQOuVW74W+N4+a+89JeB7F2PoY5bDhF5s+ YJ2RUcvksn5fnmRieUBZ8+dd8k4pMzUeVnlscmd5bVifZaEYQXUWBeZ+YkIDq6C472 6E9dmHHF3gMxQkWpN55PCMQdBZM7cEBdDspacnNw= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 44C1D6EC60 for ; Mon, 29 Mar 2021 16:01:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 44C1D6EC60 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lQrWh-0002KD-BB; Mon, 29 Mar 2021 16:01:51 +0300 Date: Mon, 29 Mar 2021 16:00:57 +0300 To: Igor Munkin Message-ID: References: <20210326164855.30242-1-skaplun@tarantool.org> <20210326203356.GJ29703@tarantool.org> <20210329111613.GN29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210329111613.GN29703@tarantool.org> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32941B7C4A78AC10F96A7797F60C25BD4B06182A05F53808504042A917911A2EF01CD24B781DF00F9F716480500132FAB4457A074F37354CA563 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637670E1B164B70895C8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662D09035DB91745CB4007D0961CA325E462A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5ECA7AF1DB3B6719A10FF955906D5F2CF7DC1A5287330D5A6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C75F910DBB8BE898F32C07E37B9960E5ECCE27CC226838918B0CAE94777AA8116E6C3D9DF6A548BD1D7E09C32AA3244C59D98BABE963588603B64781B1B9EF6A795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rRtaIUPd6eWVg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB405B53629399BCF2A8A83F8EB0FD03FCF91F97BAF187EF3B4F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 29.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the fixes! I'll push it to the trunk as soon as Sergos gives > his LGTM. > > On 29.03.21, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > > > > > > Missed ChangeLog entry, feel free to change it at your pleasure: > > Great, thanks! I propose the following wording: Thanks! I like it, exept some typos: > > | ##feature/luajit > | > | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811). > | Now the source line definition where the event occurs is much clearer: > | only source file name and allocation-related line are presented, Typo? s/are presented/is presented/ > | function definition line number is omitted. Moreover, event-related Typo: /function definition line number/the function definition line number/. > | statistics are indicated with units. > | **Breaking change**: Line info of the line function definition is > | saved in symbol info table by field `linedefined` now and field `name` > | is renamed to `source` with the respect to Lua Debug API. Typo: s/to Lua Debug/to the Lua Debug/ > > > > > -- > > > > 2.31.0 > > > > > > > > > > -- > > > Best regards, > > > IM > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun