From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DBD266EC60; Mon, 29 Mar 2021 18:56:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DBD266EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617033417; bh=09XBGYnNek05FdMe3yFsTwBjA57eDwBrBcKDNKJ0pUs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=um0CEyGvn736TUPzoyAcioljR0kCA7fic+De6A7Ifxu1G/AFbMlJmoyDUwym1PK9b W43BjZ7rUDCYwJWfNOYctPvVy8fIKPKhmJcZDd5DcGHIgMldP/D3GIBPEG1rnWUVPO FhQs+VeZ4os+hX6W4QbHz6EhK4D8IPZLSbO9RIAM= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 382736EC60 for ; Mon, 29 Mar 2021 18:56:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 382736EC60 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1lQuG7-0002S7-CS; Mon, 29 Mar 2021 18:56:55 +0300 Date: Mon, 29 Mar 2021 18:56:01 +0300 To: Sergey Ostanevich Message-ID: References: <20210326164855.30242-1-skaplun@tarantool.org> <20210326203356.GJ29703@tarantool.org> <20210329111613.GN29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F538085040A53330B7FE002453E50160692C99D8D03A184A4D2C269285533CFB4889C9202F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662D9914352A52D1A8E10413E95A1AF9E5AAA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D0061A6E5BB228CB55E92340A069F7461A4AF05A3F92F669D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EA882B598A2098111BB3773E166A00ED744EE50296FFC6653AC642E2C5973874241843DD6C83D6841D7E09C32AA3244CC712D3A1D0A0941D8271392556AFB81EFE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rSADevIxhfLew== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB40382A37620FAD1A621B149ACBE5186A468BDFECA33165F42F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! On 29.03.21, Sergey Ostanevich wrote: > Hi! > > Thank you for the patch and review! > > Let me propose some technical fix: > > long/path/to/function.lua: 3 events > very/long/path/to/function.lua: 3 events > > I think dump as above is not-so-readable for humans. A single-symbol fixup gives > > long/path/to/function.lua: 3 events > very/long/path/to/function.lua: 3 events > > + print(string.format("%s:\t%d events\t+%d bytes\t-%d bytes", > > The better solution would be to keep the longest name and append/prepend all of them > with spaces, so that the following will not happen: Yep, I agree. We should count the length of each section: * filename * number of events * allocated bytes * freed bytes I suppose, we should create a new one "good first issue" to someone to onboard in Lua and LuaJIT in particular. Thoughts? > > long/path/to/funct.lua: 3 events > very/long/path/to/funct.lua: 3 events > > > All of these are too much ‘vkusovschina’, so you have my LGTM. > > Sergos > > > > > On 29 Mar 2021, at 16:00, Sergey Kaplun > wrote: > > > > Igor, > > > > On 29.03.21, Igor Munkin wrote: > >> Sergey, > >> > >> Thanks for the fixes! I'll push it to the trunk as soon as Sergos gives > >> his LGTM. > >> > >> On 29.03.21, Sergey Kaplun wrote: > >>> Igor, > >>> > >>> Thanks for the review! > >>> > >> > >> > >> > >>> > >>> Missed ChangeLog entry, feel free to change it at your pleasure: > >> > >> Great, thanks! I propose the following wording: > > > > Thanks! I like it, exept some typos: > > > >> > >> | ##feature/luajit > >> | > >> | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811). > >> | Now the source line definition where the event occurs is much clearer: > >> | only source file name and allocation-related line are presented, > > > > Typo? s/are presented/is presented/ > > > >> | function definition line number is omitted. Moreover, event-related > > > > Typo: /function definition line number/the function definition line number/. > > > >> | statistics are indicated with units. > >> | **Breaking change**: Line info of the line function definition is > >> | saved in symbol info table by field `linedefined` now and field `name` > >> | is renamed to `source` with the respect to Lua Debug API. > > > > Typo: s/to Lua Debug/to the Lua Debug/ > > > >> > > > > > > > >>>>> -- > >>>>> 2.31.0 > >>>>> > >>>> > >>>> -- > >>>> Best regards, > >>>> IM > >>> > >>> -- > >>> Best regards, > >>> Sergey Kaplun > >> > >> -- > >> Best regards, > >> IM > > > > -- > > Best regards, > > Sergey Kaplun > -- Best regards, Sergey Kaplun