From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E73D86EC5D; Thu, 8 Apr 2021 23:19:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E73D86EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617913146; bh=IcbPjf6p40XFcfQmChwWzXAxsCDo2uNTMkoxqxod/Ok=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=STm83b4l8IurBh+lzqCYLBcdtVW5aUDzA4PGNxv4e/cosHccUknBxpKjdXgWO7Lny ZzvjKq2jRCHv0WfJt62tl+HTndaxwzWRVKHvx/aTHMwo5H4QyW7GRQkuenVYPXXqvz SXBkEQXfVE6sYpG5RzneWnmbElT8IqpT7MBPlvQs= Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4AFD66EC5D for ; Thu, 8 Apr 2021 23:19:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4AFD66EC5D Received: by mail-lj1-f172.google.com with SMTP id u9so3788873ljd.11 for ; Thu, 08 Apr 2021 13:19:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TID3eO4t58eAj553Sw0gaaPubH+iRlyszyJ0SOMI69Y=; b=h7qVCfvqq/LWOa+kyZ3e3nlVwcvQ8XYDYl1umSioMMcl9cH+b827+0nzmrgXTOMbRY 59ggYb7uYzZJ1eFl670l0QGaxcLrZ8nYepZkEWAxOPP7LD/lwmBR+BHjRAtFJuHxbaR0 pKsn9WwpLuuTdvQWme1U8XunHWXtwKuI93fusBfGn2jEhN4ekCqqj600kMuV+reKJ3Tq 5hoqwzaV/Vh7TQLHs829cVTAkejukevutUb9O/pYA2NDScswZV4m3PQG3nje07eOPyL4 hSKNA7yBz8tR0Ru4RGRf30Yyh+S34AoL4ueA6gBldfSSPFFYeuuVfK4Nby3k8HlSxLdu HZmQ== X-Gm-Message-State: AOAM5316wgeFFHoL3Tb7XMXRk15iWzghpcYr0f0xbyhs8VV69nQryv4e JT7E4jC6NTVSv8yCPwTH/4sDwmlY1YI= X-Google-Smtp-Source: ABdhPJxDkpvUmMurNUi1QPpBt7iR7y1QlvXdFdLBRHNuFIX3LgXHUcbT7t0HTg66pjqRbxvGe6a5gw== X-Received: by 2002:a2e:9090:: with SMTP id l16mr112097ljg.415.1617913143281; Thu, 08 Apr 2021 13:19:03 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id l21sm47960lfc.91.2021.04.08.13.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 13:19:02 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 7221B5601D6; Thu, 8 Apr 2021 23:19:01 +0300 (MSK) Date: Thu, 8 Apr 2021 23:19:01 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: References: <20210405155823.1121042-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 08, 2021 at 10:10:41PM +0200, Vladislav Shpilevoy wrote: > > Look, git already has the helper which does exactly what you > > prefer to see in output. I simply added this command to the > > our code-review page. If you don't like this example with > > `git log --pretty=format:"%h (%s)"` feel free to remove it > > from the page. > > Nope, I won't. The command is useful if somebody else would complain > they need a special command for that. All the amendments to the > self-review guide are appreciated. +1 Actually I've been using "git log" in a long form first and copy-pasted the output, then I recall that there definitely must be a formatter because I use "--pretty=oneline" output very often, but never the "format" option, so I dive into man and found literals to share.