From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C4F9D6EC5D; Thu, 8 Apr 2021 16:13:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4F9D6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617887593; bh=jX7AhG+Yu20/KI3YdXRUKk5c2bLY1ZtnyB+CdzQNhbs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Hh6NixkzYPBhrhPO9BCylopvwYySPfu2NexHkNKG+ltkVtCL/DlblVI576M2Y6lzX I81+lbUwkxOTEPcyKjrQjuBvzdIu3heKIJSmzhOY19jirJb24aEj9G6kCL35duMyHv j5NvVi942tF8upRDNRAhBvPLaEKEydC9Pg5Q6cvs= Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D698B6EC5D for ; Thu, 8 Apr 2021 16:13:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D698B6EC5D Received: by mail-lj1-f177.google.com with SMTP id u10so2195807lju.7 for ; Thu, 08 Apr 2021 06:13:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3RAt5obDYljKfWJ6FMBamfeLHvj96jDt3cwb9wWax10=; b=P6qsXTzEXcNpM+wxvO4/ij+DGOPbs1g3MxymE0UoXT9Bo0pe1Qey0zowm0o2kC7BTD Yk9kJ7nFKNdtCov7/Nq1MJxXAoCXx4Kn9mKYVSHkjPgD+TaDr7omAYpmPagXFVJ7T5QI Kaybn3BcyArDbEmBxgDiTHLTermOQHWPePncxvbLx+6O1cWERBlt31ZI2mg+d8YPnMCr DrKEMR711M6/KW7Sjv7Tlsjb9v6Mt6Zv/D9OkksrMei9fAL4yg5DIpqZWi6/mvTaPKff 0+UWEGK5itcpls9J2dugk6ntFad5Itm6kdRfSP9Rb6+UTAEC4DYNFfVkAkY73G2+VDHw 30cw== X-Gm-Message-State: AOAM5333wxu3CcDkjnuFp/8qAunkqfVYOe7gVbshBMFSGR+BIg5/GL+t oozXvsHQgVXwQzF4EY8SxvOtmF5WmJ4= X-Google-Smtp-Source: ABdhPJxdCiwqoQIltgzP18T1eD36vvk/NBQ7GuFVmmmXZXScNqRovQqwZCslFiM5Yw8g/WPZ0ge00g== X-Received: by 2002:a2e:924b:: with SMTP id v11mr5543265ljg.254.1617887591801; Thu, 08 Apr 2021 06:13:11 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id b6sm2816492lfv.3.2021.04.08.06.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 06:13:10 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id D7A1656015C; Thu, 8 Apr 2021 16:13:09 +0300 (MSK) Date: Thu, 8 Apr 2021 16:13:09 +0300 To: Serge Petrenko Message-ID: References: <20210408121813.1633911-1-gorcunov@gmail.com> <75632023-f2e4-b038-f800-990181566e64@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75632023-f2e4-b038-f800-990181566e64@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [PATCH v4] qsync: provide box.info.synchro interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Apr 08, 2021 at 03:58:38PM +0300, Serge Petrenko wrote: > 08.04.2021 15:18, Cyrill Gorcunov пишет: > > In commit 14fa5fd82 (cfg: support symbolic evaluation of > > replication_synchro_quorum) we implemented support of > > symbolic evaluation of `replication_synchro_quorum` parameter > > and there is no easy way to obtain it current run-time value, > > ie evaluated number value. > > > > Moreover we would like to fetch queue length on transaction > > limbo for tests and extend this statistics in future. Thus > > lets add them. > > > > Closes #5191 > > Thanks for the fixes! > > Please return `box.info.synchro.quorum` assertions to the > test regarding quorum evaluation. Like you had it in the > previous patch version. > Say like this? --- diff --git a/test/replication/qsync_basic.result b/test/replication/qsync_basic.result index 3457d2cc9..985a5baff 100644 --- a/test/replication/qsync_basic.result +++ b/test/replication/qsync_basic.result @@ -653,6 +653,13 @@ test_run:cmd('switch default') | --- | - true | ... +box.cfg{ replication_synchro_quorum = "N/2+1" } + | --- + | ... +assert(box.info.synchro.quorum == 2) + | --- + | - true + | ... test_run:cmd('stop server replica') | --- | - true diff --git a/test/replication/qsync_basic.test.lua b/test/replication/qsync_basic.test.lua index a604d80ee..a1787648f 100644 --- a/test/replication/qsync_basic.test.lua +++ b/test/replication/qsync_basic.test.lua @@ -261,6 +261,8 @@ box.space.sync:count() -- and do not switch to other nodes. -- test_run:cmd('switch default') +box.cfg{ replication_synchro_quorum = "N/2+1" } +assert(box.info.synchro.quorum == 2) test_run:cmd('stop server replica') assert(box.info.synchro.queue.len == 0) box.cfg{replication_synchro_timeout = 2}